Panic (cmd + option + P) does not work

[trevorparscal]

Describe the bug
When unhooking a midi connection while a note is on, the note off never gets sent (perhaps an all-notes off should be sent upon disconnection to avoid that). The logical remedy would be to use the key command assigned to the panic action. When using this command, nothing happens. This also occurs after the node has been reconnected.

To Reproduce
Steps to reproduce the behavior:

1. Connect MIDI input to a synth node, and that node to audio out.
2. Press a key on the MIDI keyboard.
3. Disconnect the MIDI input from the synth node.
4. Release the key on the MIDI keyboard.
5. Observe that the note is still playing.
6. Try to use the panic keyboard shortcut (cmd + option + P)
7. Observe that nothing happens.

Expected behavior
An all-notes off signal should be sent to all nodes with MIDI inputs (connected or not) when the panic command is executed. Additionally an all-notes off signal should be sent to a node when its MIDI input is disconnected and to all nodes in a graph (in single rendering mode) when switching to another graph.

Desktop (please complete the following information):

• OS: macOS Big Sur 11.2.1
• Version 1.45.1-d3f2ee9

Standalone or Plugin
Standalone

Additional context
While this may seem like an uncommon issue, when multiple MIDI devices are connected in a band situation, this happens a lot in a short period of time when one person is playing and the other person is adjusting the graph.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[mfisher31]

Ahhh yeah. having panic go direct-to-node makes alot of sense in that case of band member modifying the graph while others are playing. Also glad to see Element being used in this kind of context. People often ask, what does Element do?... and I just say "depends on what YOU build with it."