-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v25.5.0 failed to publish to npm #1600
Comments
Yes my account was added 2FA indeed. @kulshekhar should I remove 2FA or what should we do ? |
I haven't been able to find a workaround for this and I'm hesitant to remove 2FA. We'll have to publish this manually I guess. @ahnpnl if you don't get a chance to publish this manually, I'll do that by eod |
ok I will just keep the 2FA and manually publish 👍 |
tag @anshulguleria the GitHub workflow doesn't work with 2FA |
Found out that this is still an open issue. Does creating another npm account to publish sounds reasonable approach? Discussion here: nodejs/package-maintenance#244 (comment) Let me know your thoughts and in the mean time I will look into more options. |
It’s up to @kulshekhar to decide :) Side question, I see the tar file in release page contains lots of unnecessary things. Its content isn’t the same as running npm pack locally. Is there a way we can improve that ? |
I've created a new user on npm: https://www.npmjs.com/~tsjest Is there a way to re-run an action? |
You can also test with some patch release incase there is something planned. |
haha yes there will be a 25.5.1 soon :) Vue community is most likely broken with 25.5.0 |
i've disabled the requirement to have 2fa for publishing and have restarted the above job. Let's see if that works |
it worked now !! I think the publishing somehow depends on your npm account rather than a sub account that you created for only publishing. Not sure if we can have a workaround for that. |
it wasn't my account. The settings for the ts-jest package required 2fa for publishing. That's what I switched off |
I see, if it is a setting of the package itself, it looks like not possible to include 2FA into publishing process. Any thoughts @anshulguleria ? |
I haven't been able to look into this yet. I found few leads last time and I will follow up on them. For now I think you can disable 2FA and once we have some process we can change the setting. |
@kulshekhar seem like now it’s possible with new feature https://github.blog/changelog/2020-10-02-npm-automation-tokens/ |
@ahnpnl I've replaced the token with an automation token |
I think this can be closed now |
Looking at the
publish_to_npm
action for the commit that should've published 25.5.0, it failed.Did you recently add 2FA to your NPM account?
See PR #1598
The text was updated successfully, but these errors were encountered: