Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style guide to discourage use of hyperlinks in headings #48662

Open
nate-double-u opened this issue Nov 7, 2024 · 1 comment · May be fixed by #48667
Open

Update style guide to discourage use of hyperlinks in headings #48662

nate-double-u opened this issue Nov 7, 2024 · 1 comment · May be fixed by #48667
Labels
language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nate-double-u
Copy link
Contributor

nate-double-u commented Nov 7, 2024

Update Headings and titles section of the style guide to specifically discourage the use of hyperlinks in headings.

This topic came up in discussion around a blog article:

About hyperlinks in headings: having them makes the site slightly harder to maintain. We may one day want to make a change that means we first need to clean up all the headings that contain hyperlinks.

How likely is this change going to happen? Asking because I really like the idea (as I see value in it) of giving readers easy access to KEP links without venturing in the entire paragraph.

Hyperlinks in headings are rare in the Kubernetes blog (and even rarer in the documentation). Even though links in headers are not explicitly discouraged in the style guide, this can be considered an unwritten rule (Let's consider it written since Tim brought it up?). I don't recommend the practice either if for no other reason than headings become links, and having links in links gets hard to manage. If you need to link something and find the only place to do it is in a header, it's best to rewrite that paragraph to better support what you want to communicate.

Edit: I don't know how screen readers would manage links in headers either, so accessibility tools are another argument against this.

Originally posted by @nate-double-u in #48585 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2024
@dipesh-rawat
Copy link
Member

/language en
/triage accepted

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants