feat: improve network performance test to make it reusable and modifiable #2969
Conversation
k8s-ci-robot
added
kind/feature
|
Hi @ritwikranjan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ritwikranjan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
|
Hey @aojea, Can you take a look and let me know if it can be improved in any way? |
|
@wojtek-t do you know if this code is being used somewhere? |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This pull request includes significant updates to the
network/benchmarks/netperfdirectory, focusing on improving the build process, enhancing test capabilities, and updating dependencies. The most important changes include modifying theMakefileto streamline Docker builds and test execution, updating thego.modfile with new dependencies, and adding new utility libraries for Kubernetes interactions.Build and Test Improvements:
network/benchmarks/netperf/Makefile: Updated the Docker build process to use dynamic repository and image tags, added atesttarget for running Go tests, and introduced alocaltesttarget for local test execution. [1] [2] [3]Dependency Updates:
network/benchmarks/netperf/go.mod: Updated module path and dependencies to more recent versions, includingk8s.io/api,k8s.io/apimachinery, andk8s.io/client-go.New Utility Libraries:
network/benchmarks/netperf/lib/outputlib.go: Added functions for retrieving logs and data from Kubernetes pods and processing raw data into output files.network/benchmarks/netperf/lib/testlib.go: Introduced a new library for handling test parameters, performing tests, and managing Kubernetes resources.network/benchmarks/netperf/lib/utilslib.go: Added utility functions for setting up Kubernetes clients, creating services, and managing replication controllers.Which issue(s) this PR fixes:
Fixes #2876