Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config map): add binary data to config map detail page #9606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(config map): add binary data to config map detail page #9606

wants to merge 2 commits into from

Conversation

lsq645599166
Copy link
Contributor

close #9321

Add binary data to config map detail page

Screenshot

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsq645599166
Once this PR has been reviewed and has the lgtm label, please assign floreks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @lsq645599166!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2024
maciaszczykm
maciaszczykm reviewed Oct 28, 2024
View reviewed changes
modules/web/src/resource/config/configmap/detail/component.ts Outdated

return Object.entries(cm.binaryData).map(([name, value]) => ({
name,
size: atob(value).length,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we display only the length of it then I think it should be calculated on the server side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed in the latest commit

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (8c15a76) to head (d501017).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9606   +/-   ##
=======================================
  Coverage   35.88%   35.89%           
=======================================
  Files         301      301           
  Lines       14501    14502    +1     
  Branches      183      202   +19     
=======================================
+ Hits         5204     5205    +1     
+ Misses       9073     9020   -53     
- Partials      224      277   +53

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2024
@lsq645599166
Copy link
Contributor Author

image
image
@maciaszczykm The api has changed as you last comment, can you take a review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@ziyi-xie ziyi-xie Awaiting requested review from ziyi-xie

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of BinaryData fields to configmap display
3 participants
@lsq645599166 @k8s-ci-robot @maciaszczykm