Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Unit Tests for recommender/model/types.go in VPA #7434

Open
omerap12 opened this issue Oct 26, 2024 · 2 comments · May be fixed by #7482
Open

Add Missing Unit Tests for recommender/model/types.go in VPA #7434

omerap12 opened this issue Oct 26, 2024 · 2 comments · May be fixed by #7482
Assignees
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@omerap12
Copy link
Member

omerap12 commented Oct 26, 2024

Which component are you using?:
VPA

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

The VPA recommender file located at vertical-pod-autoscaler/pkg/recommender/model/types.go currently lacks complete unit test coverage. I added some tests in PR #7428, but a few functions are still missing test cases.

Describe the solution you'd like.:
Once PR #7428 is merged, add additional unit tests to ensure complete coverage of the recommender/model/types.go file.

Describe any alternative solutions you've considered.:
None.

Additional context.:
None.

@omerap12 omerap12 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2024
@omerap12
Copy link
Member Author

/assign
cc @adrianmoisey

@omerap12
Copy link
Member Author

/area vertical-pod-autoscaler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants