Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and helm chart --kube-api-burst --kube-api-qps #1666

Closed
mirajranpura opened this issue Jun 30, 2023 · 3 comments
Closed

Add documentation and helm chart --kube-api-burst --kube-api-qps #1666

mirajranpura opened this issue Jun 30, 2023 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@mirajranpura
Copy link

mirajranpura commented Jun 30, 2023

Is your feature request related to a problem?/Why is this needed

Both parameters below are important for cluster with ebs backed pvcs at scale.
--kube-api-burst
--kube-api-qps

/feature

Describe the solution you'd like in detail

  1. Add more information about such tuning parameters
  2. Include them in ebs csi helm chart

Describe alternatives you've considered
Out of band changes for existing charts

Tasks

Preview Give feedback
No tasks being tracked yet.
@torredil
Copy link
Member

torredil commented Jun 30, 2023

Hi @mirajranpura

This is already possible! We introduced an additionalArgs parameter that lets you configure optional arguments such as kube-api-qps:

additionalArgs: 
  - "--kube-api-burst=12"
  - "--kube-api-qps=7.0"

Add more information about such tuning parameters

Excellent idea, will keep this issue open to track that change. Thank you.

@torredil torredil added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 30, 2023
@torredil
Copy link
Member

Closing now that #1834 (more sensible defaults) and #1697 (documentation) have been merged.

/close

@k8s-ci-robot
Copy link
Contributor

@torredil: Closing this issue.

In response to this:

Closing now that #1834 (more sensible defaults) and #1697 (documentation) have been merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants