Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] KEP-2170: Implement MPI Plugin for Kubeflow Trainer #2394

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andreyvelich
Copy link
Member

Fixes: #2290, #2217

This is initial implementation of MPI Plugin for Kubeflow Trainer.
I am using the similar approach to generate SSH keys and ConfigMap as in MPI-Operator.

This PR will only add support for OpenMPI.

TODO list:

/cc @kubeflow/wg-training-leads @Electronic-Waste @astefanutti @tenzen-y @deepanker13 @seanlaii @saileshd1402 @kannon92 @kuizhiqing @shravan-achar @akshaychitneni @helenxie-bit @franciscojavierarceo @alculquicondor @roteme-runai @mchmarny @mlsorensen

Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: seanlaii, roteme-runai, astefanutti, shravan-achar, kannon92, mlsorensen, saileshd1402, akshaychitneni, mchmarny.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #2290, #2217

This is initial implementation of MPI Plugin for Kubeflow Trainer.
I am using the similar approach to generate SSH keys and ConfigMap as in MPI-Operator.

This PR will only add support for OpenMPI.

TODO list:

/cc @kubeflow/wg-training-leads @Electronic-Waste @astefanutti @tenzen-y @deepanker13 @seanlaii @saileshd1402 @kannon92 @kuizhiqing @shravan-achar @akshaychitneni @helenxie-bit @franciscojavierarceo @alculquicondor @roteme-runai @mchmarny @mlsorensen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we can reuse from kubeflow/mpi-operator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEP-2170: Implement Job Pipeline Framework plugins
2 participants