fix(setup.sh): Enable LLVM tools installation on Ubuntu 24.04 #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Chandra <[email protected]>
navin772
force-pushed
the
fix-ubuntu24.04
branch
from
6980678
to
ba8444a
Compare
kranurag7
requested changes
Jul 21, 2024
There was a problem hiding this comment.
thank you, the patch w.r.t. the scope looks good to me.
can you also update the following:
echo "Support Ubuntu 18.xx, 20.xx"(here 24.xx should be also included)- the go download as of now doesn't take arch into account, when you run it on arm architecture (linux, arm64) then the script fails. Either terminate the script if arch is arm64 with a helpful error message or let's modify the script so that go download takes arch into account. To maintain the consistency of go version, we can consider using
gotiphttps://github.com/golang/dl and this has to be done if go is already installed. If it's not installed then nothing needs to be done, download the latest stable go version.
|
@kranurag7 regarding the 2 point, we need # install golang
echo "Installing golang binaries..."
arch=$(uname -m)
if [ "$arch" == "aarch64" ]; then
arch="arm64"
elif [ "$arch" == "x86_64" ]; then
arch="amd64"
else
echo "Unsupported architecture: $arch"
exit 1
fi
if command -v go &>/dev/null; then
if [ "$arch" == "arm64" ]; then
echo "Go is already installed on ARM architecture, setting up gotip..."
go install golang.org/dl/gotip@latest
gotip download
echo "export PATH=\$PATH:\$HOME/sdk/gotip/bin" >> ~/.bashrc
echo "export GOTOOLDIR=\$HOME/sdk/gotip/pkg/tool/linux_arm64" >> ~/.bashrc
source ~/.bashrc
else
echo "Go is already installed."
fi
else
goBinary=$(curl -s https://go.dev/dl/ | grep "linux-$arch" | grep -Eo 'go[0-9.]+\.linux-'$arch'\.tar\.gz' | head -n 1)
wget --quiet https://dl.google.com/go/$goBinary -O /tmp/build/$goBinary
sudo tar -C /usr/local -xzf /tmp/build/$goBinary
fiI have changed how Also, shall I make a new PR for the 2nd point or update here only? |
|
When go is installed: Details
# ./go.sh
+ echo 'Installing golang binaries...'
Installing golang binaries...
++ uname -m
+ arch=aarch64
+ '[' aarch64 == aarch64 ']'
+ arch=arm64
+ command -v go
+ '[' arm64 == arm64 ']'
+ echo 'Go is already installed on ARM architecture, setting up gotip...'
Go is already installed on ARM architecture, setting up gotip...
+ go install golang.org/dl/gotip@latest
go: downloading golang.org/dl v0.0.0-20240716205829-396652c1bbd0
+ gotip download
./go.sh: line 20: gotip: command not found
+ echo 'export PATH=$PATH:$HOME/sdk/gotip/bin'
+ echo 'export GOTOOLDIR=$HOME/sdk/gotip/pkg/tool/linux_arm64'
+ source /root/.bashrc
++ '[' -z '' ']'
++ returnWhen go is not installed: Details
~ [2]# ./go.sh
+ echo 'Installing golang binaries...'
Installing golang binaries...
++ uname -m
+ arch=aarch64
+ '[' aarch64 == aarch64 ']'
+ arch=arm64
+ command -v go
++ curl -s https://go.dev/dl/
++ grep -Eo 'go[0-9.]+\.linux-arm64\.tar\.gz'
++ grep linux-arm64
++ head -n 1
+ goBinary=go1.22.5.linux-arm64.tar.gz
+ wget --quiet https://dl.google.com/go/go1.22.5.linux-arm64.tar.gz -O /tmp/build/go1.22.5.linux-arm64.tar.gz
/tmp/build/go1.22.5.linux-arm64.tar.gz: No such file or directory
+ sudo tar -C /usr/local -xzf /tmp/build/go1.22.5.linux-arm64.tar.gz
tar (child): /tmp/build/go1.22.5.linux-arm64.tar.gz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now@navin772 I've not looked into the details here but this is the raw output, ping me if you need any help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1755
LLVM tools are not installed successfully on
Ubuntu 24.04viasudo ./llvm.sh 14because of no available release channel. They need to be installed via thellvm-14-toolspackage.Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
make runfails in Ubuntu 24.04 #1755<type>(<scope>): <subject>