Cassette file paths break if test parameters include relative path-like characters

[shevron]

I am running a test that uses pytest-vcr and also has @pytest.mark.parametrize where parameters are path-segment like strings, sometimes containing relative (e.g. /../) or absolute (e.g /foo) path segments.

This causes the cassette file locations to be created all over the place, and sometimes even cause overwrite attempts of two different values point to the real file system location of a cassette file.

For example the following test:

import pytest
import requests


@pytest.mark.vcr()
@pytest.mark.parametrize('path', [
    'foo/bar',
    '/foo/bar',
    'foo/../bar',
    'foo/../../bar',
    '/../foo/bar',
    '../foo/bar',
])
def test_with_some_paths(path):
    r = requests.get('http://example.com/?q={}'.format(path))
    assert r

Assuming saved in tests/test_vcr.py, will cause .yaml files to be created all over the place. I've added spaces around directory separator to designate that these are real directories created on my file system, not literal forward-slashes which is a parts of the file / directory name:

tests / test_vcr.py
tests / bar].yaml
tests / cassettes / foo / bar].yaml
tests / cassettes / test_with_some_paths[ / foo / bar].yaml
tests / cassettes / test_with_some_paths[.. / foo / bar].yaml
tests / cassettes / test_with_some_paths[foo / bar].yaml
tests / cassettes / bar].yaml

It seems to me that some normalization and sanitization is in order when dealing with parameterized tests.