Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot deselect and delete occlusions #3

Open
TristanTrim opened this issue Jul 2, 2021 · 4 comments
Open

cannot deselect and delete occlusions #3

TristanTrim opened this issue Jul 2, 2021 · 4 comments

Comments

@TristanTrim
Copy link

Seems exclusions stay selected when I create them and when I click delete it says "Select a figure" which doesn't seem possible.
Screenshot_20210702-162049_Anki Image Occlusion
Screenshot_20210702-162137_Settings

@TristanTrim
Copy link
Author

I'm on a galaxy note 8 by the way. I think its handling of pennable input may be what's causing the problem, but idk.

@krmanik
Copy link
Owner

krmanik commented Jul 7, 2021

The problem is that when you click on screen to add a shape. Then SVG add multiple shape like circle at each corner and line etc.
Also my implementation is buggy, it needs to implement considering data structures (push/pop of shape on screen) which I have not considered earlier.

The errors can be checked using chrome dev tools inspect tools for web app.

I will take a look the errors and improve the select/deselect features.

@krmanik
Copy link
Owner

krmanik commented Jul 16, 2021

You can try the latest release from GitHub or F-Droid. (May be it takes time to be processed on F-Droid)
The delete function is improved.

To use

  • Select delete button
  • Then select shape in editor window to delete

@krmanik
Copy link
Owner

krmanik commented Jul 16, 2021

I'm on a galaxy note 8 by the way. I think its handling of pennable input may be what's causing the problem, but idk.

The main problem was event listener.
https://developer.mozilla.org/en-US/docs/Web/API/Touch_events/Using_Touch_Events

So, I added event listener to each shape when delete button selected. And remove it, when delete button deselected.
View this for more.
krmanik/image-occlusion-in-browser@1f1c2e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants