Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #2

Open
nickcmaynard opened this issue Jun 19, 2015 · 12 comments
Open

HTTPS support #2

nickcmaynard opened this issue Jun 19, 2015 · 12 comments

Comments

@nickcmaynard
Copy link

Is this plugin expected to work for HTTPS endpoints? My preliminary testing seems to show it doesn't work...

@kristianhristov
Copy link
Owner

Hi Nick,

At this time there isn't support for HTTPS. I am planning to expand the functionality of this plugin, but I don't have enough time at the moment.

Feel free to submit a pull request if you want, and I'll be happy to add it.

Cheers!

@nickcmaynard
Copy link
Author

I've only been playing with this on iOS, but I've had some success with hard-coding the "secure" attribute of the Cookie to true:

[cookieProperties setValue:@YES forKey:NSHTTPCookieSecure];

Android looks like a similar approach.

I'd guess this should be parameterised somehow.

Nothing near a pull request yet. I'll try to take a look next week.

@schoettler
Copy link

I am having an issue with getCookieValue for iOS, it returns an empty array.
Currently using iOS 9.

The parameters are alright and the same code works on Android!

@kristianhristov
Copy link
Owner

The plugin has not been tested on iOS 9. I'll have to check if something in
the native API has changed and update it. Unfortunately I'm quite busy
these days so it'd probably take me a long time to come round to it.

If you are willing, you can submit an pull request with a fix for that and
I will happily add it.

Thanks!

On 29 September 2015 at 12:30, Roberto von Schoettler <
[email protected]> wrote:

I am having an issue with getCookieValue for iOS, it returns an empty
array.
Currently using iOS 9.

The parameters are alright and the same code works on Android!


Reply to this email directly or view it on GitHub
#2 (comment)
.

Kristian Hristov
Web Developer
http://kristianhristov.com/

@schoettler
Copy link

Works fine! Just needed to include the protocol, as https://www.domain.com

@kristianhristov
Copy link
Owner

Great :)

On 29 September 2015 at 15:35, Roberto von Schoettler <
[email protected]> wrote:

Works fine! Just needed to include the protocol, as https://www.domain.com


Reply to this email directly or view it on GitHub
#2 (comment)
.

Kristian Hristov
Web Developer
http://kristianhristov.com/

@schoettler
Copy link

I created a fork to make it fit on my current project, basically just needed a method to clear all cookies at once: https://github.com/schoettler/cordova-cookie-master

@kristianhristov
Copy link
Owner

Sounds great, could you please create a pull request so I can merge your
changes in the main project.

Thanks!

On 29 September 2015 at 15:45, Roberto von Schoettler <
[email protected]> wrote:

I created a fork to make it fit on my current project, basically just
needed a method to clear all cookies at once:
https://github.com/schoettler/cordova-cookie-master


Reply to this email directly or view it on GitHub
#2 (comment)
.

Kristian Hristov
Web Developer
http://kristianhristov.com/

@schoettler
Copy link

Kristian, i have added a method to get all cookies from a domain in a JSON Object and set multiple cookies to a domain from JSON as well. I'm not an Objective C developer, so i may have done something wrong in the setCookies method which is not working, would you mind taking a look? https://github.com/schoettler/cordova-cookie-master

@kristianhristov
Copy link
Owner

Thanks for the heads up Roberto. Unfortunately I'm swamped right now, so I
won't be able to take a look any time soon.

I'll get back to you as soon as I can.

Thanks!

On 6 October 2015 at 11:51, Roberto von Schoettler <[email protected]

wrote:

Kristian, i have added a method to get all cookies from a domain in a JSON
Object and set multiple cookies to a domain from JSON as well. I'm not an
Objective C developer, so i may have done something wrong in the setCookies
method which is not working, would you mind taking a look?
https://github.com/schoettler/cordova-cookie-master


Reply to this email directly or view it on GitHub
#2 (comment)
.

Kristian Hristov
Web Developer
http://kristianhristov.com/

@schoettler
Copy link

Nevermind ~

I was missing the cookie value in the cookie properties dictionary, newbie mistake.

@graphefruit
Copy link

Any update on this? Would bei awesome to see this on https

KevinKelchen referenced this issue in Cartegraph/cordova-cookie-master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants