Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire state object passed instead of piece of state #7

Open
krfong916 opened this issue Nov 17, 2021 · 0 comments
Open

Entire state object passed instead of piece of state #7

krfong916 opened this issue Nov 17, 2021 · 0 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@krfong916
Copy link
Owner

props[stateChangeCallback]({ changes: newState });

Observed: onStateChange handlers receive the entire object
Expected: we should only pass the smallest piece of state - the state that changed
Solution: Change object. We also haven't written tests! We need to to fix this issue!

@krfong916 krfong916 added the 🐛 bug Something isn't working label Nov 17, 2021
@krfong916 krfong916 self-assigned this Nov 17, 2021
@krfong916 krfong916 mentioned this issue Nov 17, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant