Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated timeseries in CollectorRegistry #3

Open
woile opened this issue Aug 26, 2022 · 0 comments
Open

Duplicated timeseries in CollectorRegistry #3

woile opened this issue Aug 26, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@woile
Copy link
Member

woile commented Aug 26, 2022

Users have reported facing this issue:

Duplicated timeseries in CollectorRegistry

The proposal to fix it is to change arq-prometheus interfaces and instanciate it outside the startup function and receive the ctx on start.

Example:

arq_prometheus = ArqPrometheusMetrics(delay=delay, enable_webserver=True)

async def startup(ctx):
    ctx["session"] = ClientSession()
    ctx["arq_prometheus"] = await arq_prometheus.start(ctx)

As of now I don't have the means to reproduce the error, so if you face it, feel free to submit a PR fixing. Maybe the suggested implementation works.

@woile woile added the good first issue Good for newcomers label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant