-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Europe address_to_coords issue #38 is happening again #57
Comments
based on findings for issue kovacsbalu#57 updated the EU server to be SearchServer/mozi
Hi @LucidityCrash , can you please -recheck with modified BASE_COORDS? |
Assuming I understand you correctly I set the BASE_COORDS for EU in WazeRouteCalculator.py to Looks like those new BASE_COORDS are London compared to the origianals which are Budapest ? |
Yes, the original was Budapest, because I use this service with Hungarian addresses. :) |
Hmmm ... that is going to mean that the Home Assistant plugin is going to need work along side tha in order to be able to override the BASE_COORDS. I wonder why the SearchServer/mozi path works "Properly" with the Budapest BASE_COORDS while the row-SearchServer/mozi path doesn't ? |
I don'n know. I'm working on a new version which support custom base coord. |
Europe address_to_coords issue #38 is currently happening
From: 19 Albyn Drive, Livingston, UK - to: 2 Station Road, Prestonpans, UK
Start coords: (55.88032913208008, -3.524367570877075)
End coords: (52.34578323364258, 1.5044173002243042)
Time 446.55 - 493.93 minutes, distance 720.30 - 766.54 km.
Which is very much not correct. Grabbing some debug on the returned json
{'bounds': None, 'businessName': 'Starbucks Drive Through', 'city': 'Livingston', 'countryName': 'United Kingdom', 'location': {'lat': 55.88032913208008, 'lon': -3.524367570877075}, 'name': 'Starbucks Drive Through', 'number': None, 'provider': 'waze', 'segmentId': -1, 'state': 'West Lothian', 'stateName': 'No State', 'street': None, 'streetId': 0}
{'bounds': None, 'businessName': 'Station Road', 'city': 'Halesworth', 'countryName': 'United Kingdom', 'location': {'lat': 52.34578323364258, 'lon': 1.5044173002243042}, 'name': 'Station Road', 'number': None, 'provider': 'waze', 'segmentId': -1, 'state': 'Suffolk', 'stateName': 'No State', 'street': None, 'streetId': 0}
so it has found a Station Road in Halesworth not Prestonpans.
Modifying the COORD_SERVERS for EU to be SearchServer/mozi as per issue #38 the returned jsons become
{'bounds': {'bottom': 55.86370668029149, 'left': -3.518317480291502, 'right': -3.515619519708498, 'top': 55.8610087197085}, 'businessName': None, 'city': 'Murieston', 'countryName': 'United Kingdom', 'location': {'lat': 55.86235809326172, 'lon': -3.5169684886932373}, 'name': '19 Albyn Dr, Murieston, Livingston EH54 9JN', 'number': '19', 'provider': 'waze', 'segmentId': -1, 'state': 'Scotland', 'stateName': 'No State', 'street': 'Albyn Drive', 'streetId': 0}
{'bounds': {'bottom': 55.9558145802915, 'left': -2.979162080291502, 'right': -2.976464119708498, 'top': 55.9531166197085}, 'businessName': None, 'city': 'Prestonpans', 'countryName': 'United Kingdom', 'location': {'lat': 55.954463958740234, 'lon': -2.9778130054473877}, 'name': '2 Station Rd, Prestonpans EH32 9EP', 'number': '2', 'provider': 'waze', 'segmentId': -1, 'state': 'Scotland', 'stateName': 'No State', 'street': 'Station Road', 'streetId': 0}
Which is much better :)
The text was updated successfully, but these errors were encountered: