Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always open a PR for each backport label #12

Closed
korthout opened this issue Mar 23, 2021 · 1 comment
Closed

Always open a PR for each backport label #12

korthout opened this issue Mar 23, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@korthout
Copy link
Owner

When an error occurs during the execution of the backport action, we currently just comment on the original PR with the failure message. In most cases the failure is a git conflict, which needs to be resolved manually. The backport action could have already created the backport branch and opened a PR for it (although without any new commits). This would reduce the amount of manual work needed.
@korthout korthout added the enhancement New feature or request label May 17, 2021
@korthout
Copy link
Owner Author

The backport action could have already created the backport branch and opened a PR for it (although without any new commits)

GitHub does not allow creating pull requests without any commits (i.e. no diff between head and base). Instead, we can do what is suggested in #386.

Closed in favor of:

@korthout korthout closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
korthout pushed a commit that referenced this issue May 26, 2024
@AlexVermette-Eaton @vermz99
refactor for new commit conflict_resolution flag (#12)
1ec3ef4 
* changed param name

* refactor for new commit conflict_resolution flag

* refactor for new commit conflict_resolution flag

* Fix unit test

---------

Co-authored-by: Alex Vermette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@korthout