-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for move2kube-api #21
Comments
I'd like to try on this, but I'm new to Golang, could you please give me some hint like which functions need a test function? I checked your sample and noticed that not all functions have a test one. Thanks. |
@HarikrishnanBalagopal Can you give some high level guidance on how we could test this package? |
I would like to work on this @ashokponkumar |
Sure @nasirhm . |
@ashokponkumar / @HarikrishnanBalagopal Looking at the types in move2kube-api, They're all available in a single types.go: https://github.com/konveyor/move2kube-api/blob/main/internal/types/types.go . Should i begin by writing unit test cases for this one ? |
@HarikrishnanBalagopal Can you please look into @nasirhm 's question. |
Hi @nasirhm , Thanks for looking into this issue. The types package you mentioned is a good place to start since it has small functions which you can test individually. |
@ashokponkumar @HarikrishnanBalagopal can I work on this issue? |
@HarikrishnanBalagopal @ashokponkumar i have raised a PR. Please have a look |
Use the go's unit test framework similar to https://github.com/konveyor/move2kube/blob/master/types/info/versioninfo_test.go and write unit-tests for move2kube-api.
The text was updated successfully, but these errors were encountered: