Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube locks are missing an expiry mechanism #2

Open
SpComb opened this issue May 22, 2018 · 0 comments
Open

Kube locks are missing an expiry mechanism #2

SpComb opened this issue May 22, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@SpComb
Copy link
Contributor

SpComb commented May 22, 2018

If the pod holding the upgrade lock crashes and is unable to release the lock, then it should expire automatically after some --lock-expiry=6h period, allowing other nodes to continue.

Currently, if the pod restarts after crashing, it will keep the lock acquired and retry the upgrade (once scheduled)... Might be better to ensure any running host-upgrades.service is stopped after restarting, and release the lock instead?
@SpComb SpComb added the bug Something isn't working label May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpComb