Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yank does not validate yanks #65

Open
matti opened this issue Oct 3, 2018 · 2 comments
Open

yank does not validate yanks #65

matti opened this issue Oct 3, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@matti
Copy link
Contributor

matti commented Oct 3, 2018

anything is always yanked succesfully
@jnummelin jnummelin added the enhancement New feature or request label Oct 11, 2018
@jnummelin
Copy link
Contributor

By validation I think you mean that something was actually deleted? Yes, currently if you yank a non-existing shot, it's considered successful.

This needs enhancements for k8s-client too, it currently does not "report" the operations it does during shot firing.

@matti
Copy link
Contributor Author

matti commented Oct 11, 2018

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matti @jnummelin