feature: support zarf image modification in reconciliation #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR checks to see if the pod spec includes an indication that it has been manipulated by Zarf. If so, it will discern the original image string from the Zarf modified one and compare that against the incoming spec.
Why?
Without this change, the current and incoming pod specs will always be out of sync despite using identical images (albeit from different registries due to the air-gapped design of Zarf) resulting in an infinite reconciliation loop.
Additional context
This was tested in conjunction with #499 to ensure compatibility with the Istio diff logic changes.
Checklist
To Do