-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom Grunt Runner does not load properly when using 'grunt-contrib-requirejs' module #90
Comments
Can you try the latest version? It looks like in your first example there is an extra space, might be that #91 actually fixed this for you, even tho it seems unrelated. |
So now it's not detecting the gruntfile at all. Interesting. |
I copied the project to a new folder but I get the same result. I tried reloading the package just to be sure, but it doesn't work. Remember that I mentioned the panel closes itself normally when it works? i.e. When I enable the package, the panel shows up for a second, blank, and then disappears once the Grunt file is parsed. Well that doesn't happen here. The panel just shows up and never disappears: |
This is weird. Just to be sure, you can't run anything when the panel is there? |
It doesn't appear so. I tried running a few different tasks. In the previous scenario where I load the package with the "load-grunt-tasks" line commented out, it works fine and I see the correct output. In this scenario, however, it does nothing at all, and the "Start Grunt" button never changes to "Stop", even for long running tasks. |
Ok yeah, it's really weird. |
At the moment I don't have any idea regarding this issue. I have going through the code testing several approaches and preparing a new feature that aims to solve this issues. I am also thinking about writing some tests to help us a bit more in the future. @Maloric can you provide a Gist with a simple gruntfile that fails in your case? So I can test my code with it. |
Will do. My first attempt at a stripped down project with one simple grunt task does work (even with 'load-grunt-tasks'), so I'll check back in once I get it to the point of failure (at which point it should hopefully be more obvious what is happening). |
Thanks mate 👍 |
Ok, here it is. The culprit is actually |
Nice, thank you. I have also managed to replicate the issue in a project where I use grunt-contrib-requirejs. Now we might be able to debug it properly. |
Great! I've also been thinking about some tests so that's awesome that you are thinking the same. |
I actually ran into this same problem a while back on a WIndows machine. I think it has to do with the way that |
This may be a duplicate of #10 but as I have slightly different symptoms and the fix there didn't work for me, I thought I should post as a separate issue and let the community decide.
I'm using the following line to load my grunt modules:
require('load-grunt-tasks')(grunt);
My grunt tasks all run fine in PowerShell, but when trying to run via Atom, I get the following error:
Things I have tried that didn't work:
However, the following steps work:
require('load-grunt-tasks')(grunt);
line in Gruntfile.jsObviously this isn't an ideal solution, but hopefully will help someone else, either in fixing the issue or working around it for now.
The text was updated successfully, but these errors were encountered: