Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuda stream #122

Open
whuzs opened this issue Mar 25, 2023 · 8 comments
Open

cuda stream #122

whuzs opened this issue Mar 25, 2023 · 8 comments

Comments

@whuzs
Copy link

whuzs commented Mar 25, 2023

“thrust::for_each(thrust::cuda::par.on(stream), points.begin(), points.end(), accumulate_points_kernel(voxelmap_info_ptr.data(), buckets, num_points, voxel_means, voxel_covs));

thrust::for_each(thrust::counting_iterator(0), thrust::counting_iterator(voxelmap_info.num_voxels), ndt_finalize_voxels_kernel(num_points, voxel_means, voxel_covs));”

Hello, I would like to ask if these two statements are executed simultaneously. They are in different streams, but they should be executed in order logically. Why not put them in the same stream? Thank you.

@koide3
Copy link
Owner

koide3 commented Mar 27, 2023

Ah, it should be a bug. Fortunately, recent versions of thrust perform for_each in a synchronized way (regardless of the use of streams), and this does not affect programs on a recent version of CUDA. Anyways, I'll push a fix soon.

@JACKLiuDay
Copy link

Ah, it should be a bug. Fortunately, recent versions of thrust perform for_each in a synchronized way (regardless of the use of streams), and this does not affect programs on a recent version of CUDA. Anyways, I'll push a fix soon.

Hi, thank you for your work about fast gicp, I am trying to use it on my Nvidia jetson NX board. Does this fast gicp project support for Nvidia jetson board?

@whuzs
Copy link
Author

whuzs commented Mar 30, 2023

Nvidia jetson NX

i run it successfully in orin and Xavier

@JACKLiuDay
Copy link

JACKLiuDay commented Mar 30, 2023

Hi, thank you for your quick reply. You mean you run it successfully on Orin and AGX xavier? That is a good news to me. I just have a AGX xavier. And I will try it on the AGX xavier. Could you tell which jetpack you use? I just tried jetpack5.1 on NX and it did not work.

@whuzs
Copy link
Author

whuzs commented Mar 31, 2023

Orin(JetPack5.0.2.3,other default) and MIIVII Apex Xavier(default), maybe you cak take a look at #107

@JACKLiuDay
Copy link

Orin(JetPack5.0.2.3,other default) and MIIVII Apex Xavier(default), maybe you cak take a look at #107

Hi, thank you for your advice. I just looked at #107, it looks like the fix had been merged to the project master code. But my NX board still can not run gicp_kitty with fastvgivpcuda. It shows identity matrix when run gicp_kitty with fastvgicpcuda.

@JACKLiuDay
Copy link

JACKLiuDay commented Apr 7, 2023

@whuzs @koide3 Hi, I just tried fast_gicp project on AGX Xavier with jtpack5.1.1. I changed the align method with fastvgicpcuda. When I run the fast_gicp with gicp_kitti code. The result shows correct at first. Then it shows nan nan nan all the time. Could you give me some advice. Something wrong caused by arm64?
8be937c3ff05c5961095104c33986f9

@whuzs whuzs closed this as completed Apr 7, 2023
@whuzs whuzs reopened this Apr 7, 2023
@PigBroA
Copy link

PigBroA commented Feb 6, 2024

@JACKLiuDay I think you should check out whether there are nan(of inf) value in target or source cloud. you can use pcl::removeNaNFromPointCloud to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants