Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing reference to client: 'pgnative' #5997

Open
Pyrolistical opened this issue Sep 15, 2023 · 1 comment · May be fixed by knex/documentation#542
Open

Missing reference to client: 'pgnative' #5997

Pyrolistical opened this issue Sep 15, 2023 · 1 comment · May be fixed by knex/documentation#542
Labels
website

Comments

@Pyrolistical
Copy link

When #4327 was added, in order to use pg-native, the client must be change from pg to pgnative. The documentation does not describe this.
@Pyrolistical Pyrolistical mentioned this issue Sep 15, 2023
Merged
@machuga
Copy link
Contributor

machuga commented Sep 16, 2023

Hello! The docs say:

The client parameter is required and determines which client adapter will be used with the library.

But you're correct that I did not add a specific example usage. Would you like to submit a PR to add an example? Or even a code comment (similar to the SQLite area referencing better-sqlite)?

wolfhoundjesse referenced this issue in wolfhoundjesse/documentation Sep 28, 2023
@wolfhoundjesse
Add comment about driver pgnative
c1981a3 
Added a comment to the guide referencing the pgnative driver, similar
to the comment mentioning better-sqlite3. Fixes #539

Removed an unneccessary "if" from the PostgreSQL info block
@wolfhoundjesse wolfhoundjesse linked a pull request Sep 28, 2023 that will close this issue
Open
@rluvaton rluvaton added website and removed website labels Jan 31, 2024
@rluvaton rluvaton transferred this issue from knex/documentation Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comment about driver pgnative wolfhoundjesse/documentation
3 participants
@machuga @Pyrolistical @rluvaton