Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gem/Repo Owner #63

Open
mikecx opened this issue Jul 19, 2018 · 17 comments
Open

New Gem/Repo Owner #63

mikecx opened this issue Jul 19, 2018 · 17 comments

Comments

@mikecx
Copy link

mikecx commented Jul 19, 2018

Not sure there's any non-rude way to handle this but would it be possible to hand the ownership of this Ruby Gem/repo over to someone else so that this gem can be maintained and updated? Thanks for considering!

@mikecx mikecx changed the title New RubyGems Owner New Gem/Repo Owner Jul 19, 2018
@ginjo
Copy link

ginjo commented Jul 19, 2018

I think this is a reasonable request. While @kmrshntr and the others have created a wonderful gem, we have a community with a need for someone at the helm. I'm willing to collaborate with @kmrshntr and the other contributors to help update and maintain this library.

I created a fork of this gem a couple years ago to fix the bigger issues and to add some missing functionality. This has been working well for me and some others. You can see explanations of what I did in comments I left in the core slack.rb file. You can try out this fork in your own project with

gem 'omniauth-slack', github: 'ginjo/omniauth-slack'

EDIT: I just realized that my fork is not up-to-date with origin/master yet, so it is still using the older versions of omniauth-oauth2 and bundler. I'll update the fork with at least the gem spec changes.

@mikecx
Copy link
Author

mikecx commented Jul 19, 2018

@ginjo Definitely appreciate your work on keeping it up to date in your fork! The company I work at has also suggested we can take it over and maintain it if no one else wants to. We ran into an issue when relying on this in another gem we were building. The older omniauth-oauth2 dependency created all sorts of fun since .gemspecs can't point to a fork/github. Downgrading our own gem to match felt wrong but it was the only way forward right now.

All that said, since this is a great and useful gem, i'd just love to see someone maintain it however that shapes up.

@ginjo
Copy link

ginjo commented Aug 3, 2018

Hi @mikecx, just FYI I've merged (or rebased really) the ginjo fork on top of @kmrshntr master. It contains fixes, updates, and documentation... But the biggest addition is support for workspace apps and tokens.

I can push this up to rubygems.org as ginjo-omniauth-slack, though I'm not too keen on cluttering the gem space. I would still prefer to work with the maintainers of this repo to get the ginjo fork (or any part of it) merged in 😀 .

Meanwhile, if anyone wants to try it out:

gem 'omniauth-slack', git: 'https://github.com/ginjo/omniauth-slack'

@ginjo
Copy link

ginjo commented Aug 29, 2018

Just another FYI, I have released the ginjo fork as ginjo-omniauth-slack-2.4.0.gem on rubygems.org. See the readme and changelog for more info.

# Gemfile

gem 'ginjo-omniauth-slack'

@kmrshntr et al., still happy to help with the main repo any time.

@aguynamedben
Copy link

👏@ginjo

@aguynamedben
Copy link

@kmrshntr It would be really helpful to the community if you could do one final action and give @ginjo management of the repo. Or at least a deprecation warning in the repo description/README directing the community to rally behind ginjo-omniauth-slack. 🙏Thank you for the hard work you gave to this project.

@aguynamedben
Copy link

@ginjo Given the event-stream security fiasco, I'm just curious to understand where you work?

@god
Copy link

god commented May 19, 2020

God bless @mikecx for posting this.
God bless @ginjo for the wonderful work he has done with the updates.

@kmrshntr
Copy link
Owner

@aguynamedben @ginjo I'm sorry I've abandoned this repository for so long. I may have been waiting for someone else to make this issue.

@kmrshntr
Copy link
Owner

@ginjo Should I transfer ownership? Or should I just add deprecation message to description/README.

@ginjo
Copy link

ginjo commented Aug 14, 2020

Hi @kmrshntr , great to hear from you! Just off the top of my head, I think transfer of ownership on rubygems.org (assuming that's possible) and a message on the README in your github repo would seem to make the most sense. But I'm open to whatever arrangement suits you and the community best.

And of course, if you want to maintain control, you're always welcome to incorporate any/all of my work into your repo. Just let me know what you prefer, and I'll work with you. Thanks!

@ginjo
Copy link

ginjo commented Aug 14, 2020

@aguynamedben , I appreciate your concern. I'm an independent contractor/consultant in the SF Bay Area. If anyone has any questions about my code, they are welcome to review and critique my repos and the published gems.

@yurikoval
Copy link

@kmrshntr Is there an update on transfer of rubygems + repo ownership? It's frustrating having this version show up first when its functionality is stale and does not work with the new Slack API. At least having a message pointing to @ginjo 's repo in README would be nice.

@shinypancake
Copy link

Please transfer ownership!

@aguynamedben
Copy link

+1 transfer to @ginjo

@niuage
Copy link

niuage commented Jul 4, 2022

I don't understand, the owner of this gem seemed like he was agreeing on some kind of change, whether it's ownership transfer or deprecation etc. Has nothing been done since then? :'(

@marcbest
Copy link

Hey @kmrshntr, sorry to revive this thread! Is there anyway we can contribute to this repo to get it up to date? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants