Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-18 "http-client" interface instead of Guzzle #28

Open
kktsvetkov opened this issue Jul 15, 2023 · 1 comment
Open

Use PSR-18 "http-client" interface instead of Guzzle #28

kktsvetkov opened this issue Jul 15, 2023 · 1 comment

Comments

@kktsvetkov
Copy link

This project is using Guzzle as its HTTP client. Nowadays most projects (including frameworks) already have a PSR-18 compatible HTTP client library. It's been like that for some time and there are options to choose from if you want to use something different.

It will be a lot better if the selection of the HTTP client to use is left to the developer. You will remove the hard dependency to Guzzle, and make it easier to add test coverage for this project.

You can still recommend Guzzle and its adapters in composer.json as your preferred suggestion. You can also add some very quick detection of known "http-client" projects to make it easier to use with less configuration.

@southcoast-matt
Copy link

I agree. I use symphony httpclient and didn't want guzzle installed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants