feat: add TestLessThanOrEqual hint #133
Conversation
|
Hi @zmalatrax Fixed the documentation and the program comparison. I changed the PR to ready for review but if there's any modification needed please let me know. |
|
Forgot to mention that this closes #133 |
zmalatrax
dismissed
their stale review
Found a Cairo program using the TestLessThanOrEqual hint
There was a problem hiding this comment.
We've previously talked about the fact that Cairo 2.7.0 doesn't use the TestLessThanOrEqual hint when doing arithmetic comparisons. I said that we could let the Cairo programs as is, and use an older version of the compiler to test it, until we find a Cairo program that uses it for the latest Cairo version.
I've found a Cairo libfuncs that uses the TestLessThanOrEqual hint, so it can be tested with Cairo 2.7.0 :)
Note: After further thinking, if the latest Cairo version doesn't use a specific hint for one operation, another program should be written, using another operation that still uses this hint, not defaulting on "using a previous Cairo version".
Hi @zmalatrax
Changes made:
Implemented and tested the TestLessThanOrEqual hint
Here are the test results:
Please let me know if any additional modifications are needed, and I appreciate any possible feedback.