Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git clone by default into temporary directory #86

Open
shyim opened this issue Dec 5, 2023 · 1 comment
Open

Git clone by default into temporary directory #86

shyim opened this issue Dec 5, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@shyim
Copy link
Contributor

shyim commented Dec 5, 2023

It seems like right now it will be cloned into the current directory as bp. While searching something in my finder i found that folder and thought wtf is that.

I think in default it should be written to /tmp instead of CWD.

@lampajr
Copy link
Member

lampajr commented Dec 19, 2023

Hi @shyim thanks for opening this and sorry for late reply.
I might agree that setting the default directory to /tmp could be a valuable improvement (we initially approached the current working directory for historical reason that to be honest I do not recall atm).

On the other hand this somehow a breaking change because it will change the default behavior the other users might rely on and since there is a way to override the target directory using --folder I would postpone this change to the next major release.

For the records actual README highlights the default is {cwd}/bp where cwd=current working directory.

@lampajr lampajr added the good first issue Good for newcomers label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants