Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of requested user ids on Gitlab client #61

Open
lampajr opened this issue Jul 11, 2023 · 0 comments
Open

Keep track of requested user ids on Gitlab client #61

lampajr opened this issue Jul 11, 2023 · 0 comments
Labels
good first issue Good for newcomers performance Performance related task

Comments

@lampajr
Copy link
Member

lampajr commented Jul 11, 2023

In the Gitlab client we have to perform additional request to retrieve the user ids in order to correctly setup reviewers and assignees, since it could happen that an assignee is also a reviewers (especially if you consider that backporting is generally automatically executed by CI/CD tools) we could keep track of already requested user ids and check it before doing the rest call.

From a techincal point of view this could be implemented as simple key-value map where the key is the username and the value is the userId.

@lampajr lampajr added the performance Performance related task label Jul 11, 2023
@lampajr lampajr added the good first issue Good for newcomers label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers performance Performance related task
Projects
None yet
Development

No branches or pull requests

1 participant