Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(windows): Crash occurred when attempting to upgrade Keyman if the keyboard update was skipped. #12941

Open
1 of 8 tasks
dinakaranr opened this issue Jan 17, 2025 · 2 comments · May be fixed by #12948
Open
1 of 8 tasks

bug(windows): Crash occurred when attempting to upgrade Keyman if the keyboard update was skipped. #12941

dinakaranr opened this issue Jan 17, 2025 · 2 comments · May be fixed by #12948
Assignees
@rc-swag
Labels
bug windows/
Milestone
A18S20

Comments

@dinakaranr
Copy link

Describe the bug

Here, a crash dialog appeared after pressing the "yes" button on the "Do you want to allow this app to make changes to your device?" dialog appeared.

Reproduce the bug

I tested this issue with the attached "18.0.168-alpha-test-12929" build (17/01/2025) on Windows 10. Here is my observation.

Steps to reproduce 

  1. Install Keyman attached the "18.0.153-alpha-test-12840" PR build on  17/01/2025.
  2. Installed the Gff_Amharic 3.1.1 version keyboard.
  3. Open the Keyman Configuration dialog.
  4. Navigate to the "Keyboard Layouts tab".
  5. Verified that the installed keyboard shows an older version.
  6. Navigate to the "Update" tab.
  7. Press the "Check for new updates" button.
  8. Verified that the newer version appeared in the "Updated component" column for GFF's Keyboard and Keyman.
  9. Unchecked the GFF Amharic keyboard checkbox.
  10. Click the "Apply update now" button to upgrade the Keyman version.
  11. Verified that the "Keyman update" dialog appeared.
  12. Click the "Update now" button on the dialog.
  13. Verified that the "Do you want to allow this app to make changes to your device?" dialog appeared
  14. Click the "Yes" button on that dialog.
  15. Actual Results: Here, a crash dialog appeared, and then again, the "Do you want to allow this app to make changes to your device?" dialog appeared.
    Please take a look at the attached screenshot
KeymanWindowsCrashToUpdate.mp4

Expected behavior

No response

Related issues

No response

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

Lower 18.0.168-alpha-test-12929 version update to 18.0.169

Operating system

Windows

Device

No response

Target application

No response

Browser

No response

Keyboard name

gff_aharmic

Keyboard version

3.1.1

Language name

No response

Additional context

No response
@dinakaranr dinakaranr added the bug label Jan 17, 2025
@mcdurdin mcdurdin changed the title bug(Windows): Crash occurred when attempting to upgrade Keyman if the keyboard update was skipped. bug(windows): Crash occurred when attempting to upgrade Keyman if the keyboard update was skipped. Jan 18, 2025
@mcdurdin mcdurdin added this to the A18S20 milestone Jan 18, 2025
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jan 18, 2025 •
edited by mcdurdin
Loading

Sentry Issue: KEYMAN-WINDOWS-4VK

OS Version: Windows 10.0.19045 (5371)
Report Version: 104


Application Specific Information:
Exception EOleException in module kmshell.exe at 005B0E18.
The file C:\Users\Bharani\AppData\Local\Keyman\UpdateCache\gff_amharic.kmp could not be installed because of the following error: File does not exist.


Thread 0
0   kmshell.exe                     0x2c9b0e18          Keyman.System.UpdateStateMachine.InstallingState.DoInstallPackage (Keyman.System.UpdateStateMachine.pas:1000)
1   kmshell.exe                     0x2c9b0f5f          Keyman.System.UpdateStateMachine.InstallingState.DoInstallPackages (Keyman.System.UpdateStateMachine.pas:1024)
2   kmshell.exe                     0x2c9b117c          Keyman.System.UpdateStateMachine.InstallingState.HandleInstallPackages (Keyman.System.UpdateStateMachine.pas:1120)
3   kmshell.exe                     0x2c9b0082          Keyman.System.UpdateStateMachine.TUpdateStateMachine.HandleInstallPackages (Keyman.System.UpdateStateMachine.pas:551)
4   kmshell.exe                     0x2c9b8102          initprog.RunKMCOM (initprog.pas:461)
5   kmshell.exe                     0x2c9b7df8          initprog.Run (initprog.pas:348)
6   kmshell.exe                     0x2c9bb4bc          Keyman.Configuration.System.Main.RunKeymanConfiguration (Keyman.Configuration.System.Main.pas:39)
7   kmshell.exe                     0x2c9cdb18          kmshell.kmshell
8   KERNEL32.DLL                    0x75c0fcc8          BaseThreadInitThunk
9   ntdll.dll                       0x778c809d          _RtlUserThreadStart
10  ntdll.dll                       0x778c806d          _RtlUserThreadStart

@rc-swag
Copy link
Contributor

rc-swag commented Jan 20, 2025 •
edited
Loading

I am on this right now. Two problems

  1. that is trying to install the keyboard when not selected
  2. That it is throwing and exception then the file is not found rather than handling it gracefully. Fix here fix(windows): handle keyboard package not downloaded #12948

@rc-swag rc-swag linked a pull request Jan 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rc-swag rc-swag

Labels
bug windows/
Projects
Keyman
Status: No status
Milestone
A18S20
Development

Successfully merging a pull request may close this issue.

fix(windows): handle keyboard package not downloaded keymanapp/keyman
3 participants
@mcdurdin @dinakaranr @rc-swag