Policy enforcer do not handle suppressed server resources #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebondu Thanks for the PR! The changes look ok to me, but for the changes in the |
|
Hi and thanks for your feedback. Sorry, I missed the changes had to be done in the main keycloak repository. I will open the issue in main keycloak repository and create another PR. |
|
@mposolda, I created the PR for the part related to the main KC repository. Let me know if I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #137
In some scenarios, a resource may have been removed of the KC server but still exists in the path cache of the policy enforcer. Consequently, the policy enforcer cannot obtain a permission token from the KC server for these deleted resources and throw a runtime error. The policy enforcer should evict/update resources from the cache.