Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset-import.sh isn't included in the binary release of keycloak-benchmark #996

Open
paul-civitas opened this issue Oct 2, 2024 · 1 comment
Labels
dataset good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working

Comments

@paul-civitas
Copy link

Describe the bug

keycloak-benchmark-0.12-SNAPSHOT.tar.gz includes the following:

keycloak-benchmark-0.12-SNAPSHOT/bin/kcb.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/kc-failover.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/initialize-benchmark-entities.sh
keycloak-benchmark-0.12-SNAPSHOT/bin/kc-chaos.sh
keycloak-benchmark-0.12-SNAPSHOT/conf/README.adoc
keycloak-benchmark-0.12-SNAPSHOT/lib/keycloak-benchmark-0.12-SNAPSHOT.jar

But it doesn't include: dataset-import.sh which is a crucial piece of the puzzle. To get that script to run it you need to download the src.

Version

Keycloak 24, keycloak-benchmark 0.12-SNAPSHOT

Expected behavior

Scripts and binaries expected to be run by the user, are included with the binary distribution.

Actual behavior

Only some portion of the scripts are included.

How to Reproduce?

Try and run benchmarks without cloning down the src.

Anything else?

This is a minor issue

@mhajas
Copy link
Contributor

mhajas commented Oct 3, 2024

Thank you for the report @paul-civitas. You are right, the script is missing from the release. The simplest fix would be to the same as we are doing in benchmark module and package a zip file also for dataset module that would contain both, the shell script and the jar file.

We would welcome a contribution for this so feel free to open a PR against this repository if you are willing to contribute.

@mhajas mhajas added kind/bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed dataset labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants