stringify: do not use unescapedIndexOf in property parameters #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Sep 17, 2022
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#535
Pull Request Test Coverage Report for Build 3073650642
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3572936717
💛 - Coveralls |
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Sep 18, 2022
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#535
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly.
dilyanpalauzov
force-pushed
the
stringify_propertyParameterValue_escape
branch
from
878fac2
to
b23d9ef
Compare
|
Now updated to the ES6 changes. |
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Nov 29, 2022
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#535 ES6-ready
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Nov 29, 2022
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#535
Closed
|
Superseded by #658. |
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Apr 13, 2024
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#658 This supersedes kewisch#535 and updates kewisch#555 . Without these changes, the herein added test fails: 1) ICAL.stringify stringify property stringify property value containing "escaped" ; , :: AssertionError: expected 'ATTENDEE;CN=X\::mailto:id' to equal 'ATTENDEE;CN="X\:":mailto:id' + expected - actual -ATTENDEE;CN=X\::mailto:id +ATTENDEE;CN="X\:":mailto:id
dilyanpalauzov
added a commit
to dilyanpalauzov/ical.js
that referenced
this pull request
Apr 20, 2024
… as \ is no escape character there. When the propery parameter contains :, then it must be quoted, the colon cannot be escaped. As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly. kewisch#658 This supersedes kewisch#535 and updates kewisch#555 . Without these changes, the herein added test fails: 1) ICAL.stringify stringify property stringify property value containing "escaped" ; , :: AssertionError: expected 'ATTENDEE;CN=X\::mailto:id' to equal 'ATTENDEE;CN="X\:":mailto:id' + expected - actual -ATTENDEE;CN=X\::mailto:id +ATTENDEE;CN="X\:":mailto:id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as \ is no escape character there.
When the propery parameter contains :, then it must be quoted, the colon cannot be escaped.
As the function stringify.propertyValue in fact stringifies property parameter values, it is renamed accordingly.