Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http4s instead of github-api #146

Closed
6 tasks done
kevin-lee opened this issue Jan 17, 2021 · 1 comment · Fixed by #159
Closed
6 tasks done

Use http4s instead of github-api #146

kevin-lee opened this issue Jan 17, 2021 · 1 comment · Fixed by #159
Assignees
@kevin-lee
Labels
task Task to do
Milestone
milestone8

Comments

@kevin-lee
Copy link
Owner

kevin-lee commented Jan 17, 2021 •
edited
Loading

Task

Summary

Use http4s instead of github-api

Project Details

Version: 1.0.3

Description

Use http4s instead of github-api. github4s was also considered but declined.
Since github4s doesn't support uploading assets to release, it is required to use HTTP client library to do both release and loading. So use http4s instead of github4s which means http4s/http4s#140 can be dropped.

  • New data types for GitHub release
  • Add create GitHub release
  • Add find GitHub release
  • Add update GitHub release
  • Add upload assets to GitHub release
  • Replace the OldGitHubApi with the new GitHubApi.
@kevin-lee kevin-lee added the task Task to do label Jan 17, 2021
@kevin-lee kevin-lee added this to the milestone8 milestone Jan 17, 2021
@kevin-lee kevin-lee self-assigned this Jan 17, 2021
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Issue #146 - Remove github4s from buld.sbt
f6e41e0
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Issue #146 - Add HttpClient using http4s
2d17df4
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Issue #146 - Remove github4s from build.sbt
c69ba54
@kevin-lee kevin-lee mentioned this issue Jan 20, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Merge pull request #147 from Kevin-Lee/task/146/remove-github4s-from-…
8801f97 
…build.sbt

Issue #146 - Remove github4s from build.sbt
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Issue #146 - Add HttpClient using http4s
4aafadc
@kevin-lee kevin-lee mentioned this issue Jan 20, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Issue #146 - Add HttpClient using http4s
e5e393f
kevin-lee added a commit that referenced this issue Jan 20, 2021
@kevin-lee
Merge pull request #148 from Kevin-Lee/task/146/add-http-client-code
66b88d7 
Issue #146 - Add HttpClient using http4s
kevin-lee added a commit that referenced this issue Jan 21, 2021
@kevin-lee
Issue #146 - Some changes in existing types including errors
edb158d
@kevin-lee kevin-lee mentioned this issue Jan 21, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 21, 2021
@kevin-lee
Merge pull request #149 from Kevin-Lee/task/146/add-create-github-rel…
ad1c7ad 
…ease

Issue #146 - Some changes in existing types including errors
kevin-lee added a commit that referenced this issue Jan 21, 2021
@kevin-lee
Issue #146 - New data types for GitHub release
62e86d4
@kevin-lee kevin-lee mentioned this issue Jan 21, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 21, 2021
@kevin-lee
Merge pull request #150 from Kevin-Lee/task/146/new-data-types-for-gi…
34ff9b3 
…thub-release

Issue #146 - New data types for GitHub release
kevin-lee added a commit that referenced this issue Jan 22, 2021
@kevin-lee
Issue #146 - Add 'create GitHub release'
676fe5f
@kevin-lee kevin-lee mentioned this issue Jan 22, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 22, 2021
@kevin-lee
Merge pull request #151 from Kevin-Lee/task/146/create-github-release
cc5a846 
Issue #146 - Add 'create GitHub release'
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Issue #146 - Add 'find GitHub release'
d6bb9c4
@kevin-lee kevin-lee mentioned this issue Jan 23, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Merge pull request #152 from Kevin-Lee/task/146/add-find-github-release
a0a6f9e 
Issue #146 - Add 'find GitHub release'
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Issue #146 - Add 'update GitHub release'
b395408
@kevin-lee kevin-lee mentioned this issue Jan 23, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Merge pull request #153 from Kevin-Lee/task/146/add-update-github-rel…
3872634 
…ease

Issue #146 - Add 'update GitHub release'
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Issue #146 - A simpler way to handle request body JSON
748cd75
@kevin-lee kevin-lee mentioned this issue Jan 23, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 23, 2021
@kevin-lee
Merge pull request #154 from Kevin-Lee/task/146/simpler-way-to-handle…
a5d52aa 
…-request-body-json

Issue #146 - A simpler way to handle request body JSON
kevin-lee added a commit that referenced this issue Jan 28, 2021
@kevin-lee
Issue #146 - Add upload assets to GitHub release
04b73cd
@kevin-lee kevin-lee mentioned this issue Jan 28, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 28, 2021
@kevin-lee
Merge pull request #155 from Kevin-Lee/task/146/add-upload-assets-to-…
ff984f8 
…github-release

Issue #146 - Add upload assets to GitHub release
kevin-lee added a commit that referenced this issue Jan 28, 2021
@kevin-lee
Issue #146 - Added: authentication to GitHub API failure handling
4465363
@kevin-lee kevin-lee mentioned this issue Jan 28, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 28, 2021
@kevin-lee
Merge pull request #157 from Kevin-Lee/task/146/add-auth-failure-hand…
9a01db3 
…ling

Issue #146 - Added: authentication to GitHub API failure handling
@kevin-lee
Copy link
Owner Author

This is blocked by http4s/blaze#639. 😭

kevin-lee added a commit that referenced this issue Jan 30, 2021
@kevin-lee
Issue #146 - Fixed: A bug in uploading a bigger file to GitHub release
11a8642
kevin-lee added a commit that referenced this issue Jan 30, 2021
@kevin-lee
Issue #146 - Fixed: A bug in uploading a bigger file to GitHub release
c0f3895
@kevin-lee kevin-lee mentioned this issue Jan 30, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 30, 2021
@kevin-lee
Issue #146 - Fixed: A bug in uploading a bigger file to GitHub release
6e77f6f
kevin-lee added a commit that referenced this issue Jan 30, 2021
@kevin-lee
Issue #146 - Fixed: A bug in uploading a bigger file to GitHub release
f2449e8
kevin-lee added a commit that referenced this issue Jan 30, 2021
@kevin-lee
Merge pull request #158 from Kevin-Lee/bug/146/fix-bigger-file-upload…
32d0a21 
…-to-github-release

Issue #146 - Fixed: A bug in uploading a bigger file to GitHub release
kevin-lee added a commit that referenced this issue Jan 31, 2021
@kevin-lee
Close #146 - Use http4s instead of github4s
ed0738f
@kevin-lee kevin-lee mentioned this issue Jan 31, 2021
Merged
kevin-lee added a commit that referenced this issue Jan 31, 2021
@kevin-lee
Merge pull request #159 from Kevin-Lee/task/146/use-http4s-to-use-git…
41e82be 
…hub-api

Close #146 - Use http4s instead of github4s
@kevin-lee kevin-lee mentioned this issue Jan 31, 2021
Closed
@kevin-lee kevin-lee changed the title Use http4s instead of github4s Use http4s instead of github-api Feb 7, 2021
@kevin-lee kevin-lee mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-lee kevin-lee

Labels
task Task to do
Projects
None yet
Milestone
milestone8
Development

Successfully merging a pull request may close this issue.

Close #146 - Use http4s instead of github4s kevin-lee/sbt-devoops
1 participant
@kevin-lee