Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further encoding support #11

Open
2 of 5 tasks
kellerkindt opened this issue Apr 22, 2020 · 0 comments
Open
2 of 5 tasks

Further encoding support #11

kellerkindt opened this issue Apr 22, 2020 · 0 comments

Comments

@kellerkindt
Copy link
Owner

kellerkindt commented Apr 22, 2020 •
edited
Loading

Issue Tracking Issue for tracking the progress of further encoding implementation.

Preconditions:

  • (in progress, clean-up) Refactor to provide better extensibility (see 325c96f and asn1rs::syn)

Potential encodings:
kellerkindt added a commit that referenced this issue Apr 22, 2020
@kellerkindt
Add draft implementation of a new type representation to reduce compl…
325c96f 
…exity

The current approach to generate the (de-)serialization code is to messy,
too hard to understand, too hard to extend and too complex. The new idea is
to introduce a further codegen step.

1) ASN Definition   -- old codegen -->  3) Rust struct with (de-)serializable

   |                                                    A
   | generate                                proc-macro |
   V                                                    |

 2) Rust struct with attributes and that pleasant for human eyes

Instead of writing 3) to the user file, 2) shall now be written instead.
Also, instead of generate comple (de-)serializ code in 3), the Visitor
pattern is being used to walk the types and values on the generated data
types. This hopefully allows to implement UPER, PER, BER, ... #1 #10 #11
kellerkindt added a commit that referenced this issue Apr 22, 2020
@kellerkindt
Add concept of how asn proc_macro_attributes should look like #11
5239274
@kellerkindt kellerkindt mentioned this issue Apr 22, 2020
Open
kellerkindt added a commit that referenced this issue Apr 22, 2020
@kellerkindt
Add the println output for the current example #11
14db159
kellerkindt added a commit that referenced this issue Apr 24, 2020
@kellerkindt
Implement basic attribute parsing and code generation from that #11
bd0d3f2
kellerkindt added a commit that referenced this issue Apr 27, 2020
@kellerkindt
Implement an UperWriter for the (for now) very basic Writer trait #11 #6
c1168d8
kellerkindt added a commit that referenced this issue Apr 27, 2020
@kellerkindt
Implement an UperReader for the (for now) very basic Reader trait #11 #6
c91ab54
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Implement read/write_enumerated #11
12bdfc4
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Parse and generate impls for enums with #[asn(enumerated)] attributes #…
cce4c27 
…11
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Support Complex type composition (like an ENUMERATED in a SEQUENCE) #11
faeb91c
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Add support for declarative CHOICE types #11
3f5fe3a
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Support OCTET STRING in declarativ notation #11
6ae4163
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Support SEQUENCE OF in fields #11
075e5d9
kellerkindt added a commit that referenced this issue Apr 30, 2020
@kellerkindt
Support transparent ASN types - where there is only one unnamed field #…
bad87a0 
…11
kellerkindt added a commit that referenced this issue May 4, 2020
@kellerkindt
Support BOOLEAN asn types and rename asn-attribute optional to option #…
5d79ac9 
…11
kellerkindt added a commit that referenced this issue May 4, 2020
@kellerkindt
Properly parse negative range values, expect the type for complex asn…
7de0269 
…-attributes #11
kellerkindt added a commit that referenced this issue May 4, 2020
@kellerkindt
Generate structs with the new asn-attributes #11
5d3507c
kellerkindt added a commit that referenced this issue May 4, 2020
@kellerkindt
PERF: Remove need of vector for handling optional flags #11
68d0a05
kellerkindt added a commit that referenced this issue May 7, 2020
@kellerkindt
Write and parse extensible_after for CHOICE and ENUMERATED #11
95d2953
kellerkindt added a commit that referenced this issue May 7, 2020
@kellerkindt
Properly pass on parsed tag values #11
5d7db2b
kellerkindt added a commit that referenced this issue Oct 1, 2020
@kellerkindt
Resolve tags while transforming a model from Asn to Rust #13 #11
6c3c93a
kellerkindt added a commit that referenced this issue Oct 9, 2020
@kellerkindt
Add common::Constraint which always provides a Tag for the current ty…
cfb2101 
…pe, fixes #13

Resolve all tags while augmenting the annotated structs with Constraint impls. It
is neccessary that to this state, the complex-type-references have already resolved
their tags. For this it it might be neccessary from now on to have all *.asn1 files
and their modules in scope while resolving the tags in the RustModel-to-Annotation
stage.

Quite a bit of work went into ensuring that no unncessary tags (meaning default tags)
are present in the annotated representation to prevent unnecessary bloat.

This will probably allow the SET and SET_OF branch to be merged soon #11 #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kellerkindt