Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing a new version #134

Closed
kazu-yamamoto opened this issue Jul 11, 2024 · 7 comments
Closed

Releasing a new version #134

kazu-yamamoto opened this issue Jul 11, 2024 · 7 comments

Comments

@kazu-yamamoto
Copy link
Owner

@edsko @FinleyMcIlwaine To release a new version, we should agree with/check:

@FinleyMcIlwaine
Copy link
Collaborator

I think the change in behavior is enough to warrant a bump to 5.3.0. I am not sure yet whether our throughput has been affected. Once I determine what is going on with the empty data frames in our benchmark I will be able to do throughput tests.

As I'm debugging that benchmark, I am still seeing these kinds of window updates in wireshark:

Screenshot 2024-07-11 at 3 43 57 PM

I believe this shows three packets holding six consecutive window updates for the same stream, one being a 9 byte increment, and the rest varying in size from 4069 bytes to 36783 bytes. Does this look like expected behavior? Either way, the small window updates doesn't seem like big enough deal to hold up this release.

Thanks for looping us in @kazu-yamamoto!

@kazu-yamamoto
Copy link
Owner Author

The version has bumped to 5.3.0 on the main branch.

The behavior of window update is not what I expect.
I should dig it.

@kazu-yamamoto
Copy link
Owner Author

Now I can reproduce the window issue.
Let me consider how to fix it.

@FinleyMcIlwaine
Copy link
Collaborator

@kazu-yamamoto We have submitted some patches that fix the empty data frames we were seeing. It would be ideal if those patches were included in the next releases of http2 and http-semantics. If those are in, I think we are ready for a release.

@kazu-yamamoto
Copy link
Owner Author

@edsko @FinleyMcIlwaine I'm going to release the following packages:

  • http-semantics v0.2.0
  • http2 v5.3.0
  • http2-tls v0.4.1

Any objections?

I would like to release network-control when the small window update is fixed.

@FinleyMcIlwaine
Copy link
Collaborator

@kazu-yamamoto Looks good to us!

@kazu-yamamoto
Copy link
Owner Author

The four packages above have been released.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants