-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releasing a new version #134
Comments
I think the change in behavior is enough to warrant a bump to 5.3.0. I am not sure yet whether our throughput has been affected. Once I determine what is going on with the empty data frames in our benchmark I will be able to do throughput tests. As I'm debugging that benchmark, I am still seeing these kinds of window updates in wireshark: I believe this shows three packets holding six consecutive window updates for the same stream, one being a 9 byte increment, and the rest varying in size from 4069 bytes to 36783 bytes. Does this look like expected behavior? Either way, the small window updates doesn't seem like big enough deal to hold up this release. Thanks for looping us in @kazu-yamamoto! |
The version has bumped to 5.3.0 on the The behavior of window update is not what I expect. |
Now I can reproduce the window issue. |
@kazu-yamamoto We have submitted some patches that fix the empty data frames we were seeing. It would be ideal if those patches were included in the next releases of |
@edsko @FinleyMcIlwaine I'm going to release the following packages:
Any objections? I would like to release |
@kazu-yamamoto Looks good to us! |
The four packages above have been released. |
@edsko @FinleyMcIlwaine To release a new version, we should agree with/check:
http2
sends lots of small window size updates for the connection #129?The text was updated successfully, but these errors were encountered: