Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourites not working properly #104

Open
kasnerz opened this issue Feb 24, 2023 · 1 comment
Open

Favourites not working properly #104

kasnerz opened this issue Feb 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kasnerz
Copy link
Owner

kasnerz commented Feb 24, 2023

  • Trying to remove a favourite example triggers
Failed to store action to server: Removed favourite totto-dev-6270-undefined-undefined

on the frontend and

Traceback (most recent call last):
  File "/home/kasner/virtualenv/tabgenie/lib/python3.8/site-packages/flask/app.py", line 2525, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/kasner/virtualenv/tabgenie/lib/python3.8/site-packages/flask/app.py", line 1822, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/kasner/virtualenv/tabgenie/lib/python3.8/site-packages/flask/app.py", line 1820, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/kasner/virtualenv/tabgenie/lib/python3.8/site-packages/flask/app.py", line 1796, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/home/kasner/tabgenie/tabgenie/main.py", line 403, in favourite
    assert dataset and split and isinstance(table_idx, int), (dataset, split, table_idx)
AssertionError: ('totto-dev-6270', None, None)

on the backend.

  • After clicking on the favourite example, the app sometimes shows the first example in the split instead. It seems non-deterministic - some timing between the javascript requests?
@kasnerz kasnerz added the bug Something isn't working label Feb 24, 2023
@kategerasimenko
Copy link
Collaborator

look at #96 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants