From 275fd96b65ae25ef072b2eb1f0a9621ec1f69feb Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 19:25:21 +0800
Subject: [PATCH 1/7] Add helper to process the time-tag string format as test
 case.

---
 .../Helper/TestCaseTagHelper.cs               | 31 ++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/osu.Framework.Font.Tests/Helper/TestCaseTagHelper.cs b/osu.Framework.Font.Tests/Helper/TestCaseTagHelper.cs
index 5076971..6637059 100644
--- a/osu.Framework.Font.Tests/Helper/TestCaseTagHelper.cs
+++ b/osu.Framework.Font.Tests/Helper/TestCaseTagHelper.cs
@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
 using osu.Framework.Graphics.Sprites;
@@ -41,7 +42,35 @@ public static PositionText ParsePositionText(string str)
             };
         }
 
-        public static PositionText[] ParseParsePositionTexts(string[] strings)
+        /// <summary>
+        /// Process test case time tag string format into <see cref="Tuple"/>
+        /// </summary>
+        /// <example>
+        /// [0,start]:1000
+        /// </example>
+        /// <param name="str">Time tag string format</param>
+        /// <returns><see cref="Tuple"/>Time tag object</returns>
+        public static Tuple<TextIndex, double> ParseTimeTag(string str)
+        {
+            if (string.IsNullOrEmpty(str))
+                return new Tuple<TextIndex, double>(new TextIndex(), 0);
+
+            var regex = new Regex("(?<index>[-0-9]+),(?<state>start|end)]:(?<time>[-0-9]+|s*|)");
+            var result = regex.Match(str);
+            if (!result.Success)
+                throw new RegexMatchTimeoutException(nameof(str));
+
+            int index = int.Parse(result.Groups["index"].Value);
+            var state = result.Groups["state"].Value == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
+            double time = string.IsNullOrEmpty(result.Groups["time"].Value) ? 0 : double.Parse(result.Groups["time"].Value);
+
+            return new Tuple<TextIndex, double>(new TextIndex(index, state), time);
+        }
+
+        public static PositionText[] ParseParsePositionTexts(IEnumerable<string> strings)
             => strings?.Select(ParsePositionText).ToArray();
+
+        public static IReadOnlyDictionary<TextIndex, double> ParseTimeTags(IEnumerable<string> strings)
+            => strings?.Select(ParseTimeTag).ToDictionary(k => k.Item1, k => k.Item2);
     }
 }

From e492d1b28bd47eb05354b6716bfe521c33820ecd Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 21:22:56 +0800
Subject: [PATCH 2/7] Use helper.

---
 .../Sprites/TestSceneKaraokeSpriteText.cs     | 34 ++-----------------
 1 file changed, 3 insertions(+), 31 deletions(-)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
index 400f9dd..aa49a1a 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
@@ -1,4 +1,4 @@
-// Copyright (c) karaoke.dev <contact@karaoke.dev>. Licensed under the MIT Licence.
+// Copyright (c) karaoke.dev <contact@karaoke.dev>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
 using System.Collections.Generic;
@@ -22,36 +22,8 @@ public TestSceneKaraokeSpriteText()
             Child = karaokeSpriteText = new KaraokeSpriteText
             {
                 Text = "カラオケ！",
-                Rubies = new[]
-                {
-                    new PositionText
-                    {
-                        StartIndex = 0,
-                        EndIndex = 1,
-                        Text = "か"
-                    },
-                    new PositionText
-                    {
-                        StartIndex = 2,
-                        EndIndex = 3,
-                        Text = "お"
-                    }
-                },
-                Romajies = new[]
-                {
-                    new PositionText
-                    {
-                        StartIndex = 1,
-                        EndIndex = 2,
-                        Text = "ra"
-                    },
-                    new PositionText
-                    {
-                        StartIndex = 3,
-                        EndIndex = 4,
-                        Text = "ke"
-                    }
-                },
+                Rubies = TestCaseTagHelper.ParseParsePositionTexts(new[] { "[0,1]:か", "[2,3]:お" }),
+                Romajies = TestCaseTagHelper.ParseParsePositionTexts(new[] { "[1,2]:ra", "[3,4]:ke" }),
                 LeftTextColour = Color4.Green,
                 RightTextColour = Color4.Red,
             };

From d0ac97c5edcb78af780daa6dfa3117d83b97731e Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 19:57:51 +0800
Subject: [PATCH 3/7] Remove the un-need parts. Will add another test cases for
 time-tags.

---
 .../Sprites/TestSceneKaraokeSpriteText.cs     | 75 +------------------
 1 file changed, 2 insertions(+), 73 deletions(-)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
index aa49a1a..94f851b 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
@@ -31,7 +31,7 @@ public TestSceneKaraokeSpriteText()
 
         [TestCase(false)]
         [TestCase(true)]
-        public void TestKaraokeSpriteTextTimeTag(bool manualTime)
+        public void TestKaraokeSpriteTextClock(bool manualTime)
         {
             if (manualTime)
             {
@@ -41,7 +41,7 @@ public void TestKaraokeSpriteTextTimeTag(bool manualTime)
                 });
             }
 
-            AddStep("Default time tag", () =>
+            AddStep("Apply time-tags", () =>
             {
                 var startTime = getStartTime();
 
@@ -55,77 +55,6 @@ public void TestKaraokeSpriteTextTimeTag(bool manualTime)
                     { new TextIndex(4), startTime + 2000 },
                 };
             });
-            AddStep("Time tag with end state", () =>
-            {
-                var startTime = getStartTime();
-
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    // カ
-                    { new TextIndex(0), startTime + 0 },
-                    { new TextIndex(0, TextIndex.IndexState.End), startTime + 100 },
-                    // ラ
-                    { new TextIndex(1), startTime + 1000 },
-                    { new TextIndex(1, TextIndex.IndexState.End), startTime + 1100 },
-                    // オ
-                    { new TextIndex(2), startTime + 2000 },
-                    { new TextIndex(2, TextIndex.IndexState.End), startTime + 2100 },
-                    // ケ
-                    { new TextIndex(3), startTime + 3000 },
-                    { new TextIndex(3, TextIndex.IndexState.End), startTime + 3100 },
-                    // !
-                    { new TextIndex(4), startTime + 4000 },
-                    { new TextIndex(4, TextIndex.IndexState.End), startTime + 4100 },
-                };
-            });
-            AddStep("Time tag with wrong order", () =>
-            {
-                var startTime = getStartTime();
-
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    { new TextIndex(4), startTime + 2000 },
-                    { new TextIndex(3), startTime + 1500 },
-                    { new TextIndex(2), startTime + 1000 },
-                    { new TextIndex(1), startTime + 600 },
-                    { new TextIndex(0), startTime + 500 },
-                };
-            });
-            AddStep("Time tag with out of range", () =>
-            {
-                var startTime = getStartTime();
-
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    { new TextIndex(-1), startTime + 0 },
-                    { new TextIndex(0), startTime + 500 },
-                    { new TextIndex(1), startTime + 600 },
-                    { new TextIndex(2), startTime + 1000 },
-                    { new TextIndex(3), startTime + 1500 },
-                    { new TextIndex(4), startTime + 2000 },
-                    { new TextIndex(8), startTime + 2500 },
-                };
-            });
-
-            AddStep("Only one time-tag", () =>
-            {
-                var startTime = getStartTime();
-
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    { new TextIndex(0), startTime + 500 },
-                };
-            });
-
-            AddStep("None time-tag", () =>
-            {
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = null;
-            });
 
             double getStartTime()
                 => manualTime ? 0 : Clock.CurrentTime;

From 5670cc7529d10b2162adeece6baa84fb9c873363 Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 20:53:38 +0800
Subject: [PATCH 4/7] Add test case for the time-tag.

---
 .../Visual/Sprites/TestSceneKaraokeSpriteText.cs | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
index 94f851b..d72bb56 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System.Collections.Generic;
+using System.Linq;
 using NUnit.Framework;
 using osu.Framework.Font.Tests.Helper;
 using osu.Framework.Graphics.Sprites;
@@ -60,6 +61,21 @@ double getStartTime()
                 => manualTime ? 0 : Clock.CurrentTime;
         }
 
+        [TestCase(new[] { "[0,start]:500", "[1,start]:600", "[2,start]:1000", "[3,start]:1500", "[4,start]:2000" }, true)] // Normal time-tag.
+        [TestCase(new[] { "[0,start]:0", "[0,end]:100", "[1,start]:1000", "[1,end]:1100", "[2,start]:2000", "[2,end]:2100", "[3,start]:3000", "[3,end]:3100", "[4,start]:4000", "[4,end]:4100" }, true)]
+        [TestCase(new[] { "[-1,start]:0", "[0,start]:500", "[1,end]:600", "[2,start]:1000", "[3,end]:1500", "[4,end]:2000", "[8,end]:2500" }, true)] // Out-of-range time-tag, but it's acceptable now.
+        [TestCase(new[] { "[0,start]:500" }, true)] // Only one time-tag.
+        public void TestKaraokeSpriteTextTimeTags(string[] timeTags, bool boo)
+        {
+            AddStep("Apply time-tags", () =>
+            {
+                var startTime = Clock.CurrentTime;
+
+                karaokeSpriteText.TimeTags = TestCaseTagHelper.ParseTimeTags(timeTags)
+                                                              .ToDictionary(k => k.Key, v => v.Value + startTime);
+            });
+        }
+
         [Test]
         public void TestChangeText()
         {

From 17c55b6ac4c017486b52a90e2ed61e710a4e0cd7 Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 21:16:41 +0800
Subject: [PATCH 5/7] re-write the test case follow how
 `TestSceneLyricSpriteText` did.

---
 .../Sprites/TestSceneKaraokeSpriteText.cs     | 126 ++++++------------
 1 file changed, 44 insertions(+), 82 deletions(-)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
index d72bb56..9dc3f4d 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
@@ -8,7 +8,6 @@
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Testing;
 using osu.Framework.Timing;
-using osuTK;
 using osuTK.Graphics;
 
 namespace osu.Framework.Font.Tests.Visual.Sprites
@@ -76,64 +75,45 @@ public void TestKaraokeSpriteTextTimeTags(string[] timeTags, bool boo)
             });
         }
 
-        [Test]
-        public void TestChangeText()
+        [TestCase("カラオケー")]
+        public void TestText(string text)
         {
-            AddStep("Change texr", () =>
+            AddStep("Change text", () =>
             {
-                karaokeSpriteText.Text = "カラオケー";
+                karaokeSpriteText.Text = text;
             });
         }
 
-        [Test]
-        public void TestChangeRuby()
+        [TestCase(new[] { "[0,1]:123aaa", "[1,2]:ら", "[2,3]:お", "[3,4]:け" }, true)]
+        public void TestRuby(string[] rubyTags, bool boo)
         {
             AddStep("Change ruby", () =>
             {
-                var rubyTags = new[] { "[0,1]:123aaa", "[1,2]:ら", "[2,3]:お", "[3,4]:け" };
                 var ruby = TestCaseTagHelper.ParseParsePositionTexts(rubyTags);
                 karaokeSpriteText.Rubies = ruby;
             });
         }
 
-        [Test]
-        public void TestChangeRomaji()
+        [TestCase(new[] { "[0,1]:ka", "[1,2]:ra", "[2,3]:o", "[3,4]:ke" }, true)]
+        public void TestRomaji(string[] romajiTags, bool boo)
         {
             AddStep("Change romaji", () =>
             {
-                var romajiTags = new[] { "[0,1]:ka", "[1,2]:ra", "[2,3]:o", "[3,4]:ke" };
                 var romajies = TestCaseTagHelper.ParseParsePositionTexts(romajiTags);
                 karaokeSpriteText.Romajies = romajies;
             });
         }
 
-        [Test]
-        public void TestChangeFont()
+        [TestCase(48, 24, 24)]
+        [TestCase(48, 10, 24)]
+        [TestCase(48, 24, 10)]
+        public void TestFont(int mainFontSize, int rubyFontSize, int romajiFontSize)
         {
             AddStep("Change font", () =>
             {
-                var font = FontUsage.Default.With(size: 64);
-                karaokeSpriteText.Font = font;
-            });
-        }
-
-        [Test]
-        public void TestChangeRubyFont()
-        {
-            AddStep("Change ruby font", () =>
-            {
-                var font = FontUsage.Default.With(size: 24);
-                karaokeSpriteText.RubyFont = font;
-            });
-        }
-
-        [Test]
-        public void TestChangeRomajiFont()
-        {
-            AddStep("Change romaji font", () =>
-            {
-                var font = FontUsage.Default.With(size: 24);
-                karaokeSpriteText.RomajiFont = font;
+                karaokeSpriteText.Font = new FontUsage(null, mainFontSize);
+                karaokeSpriteText.RubyFont = new FontUsage(null, rubyFontSize);
+                karaokeSpriteText.RomajiFont = new FontUsage(null, romajiFontSize);
             });
         }
 
@@ -142,6 +122,7 @@ public void TestLeftTextColour()
         {
             AddStep("Change left text colour", () =>
             {
+                // note: usually we use shader to adjust the style.
                 karaokeSpriteText.LeftTextColour = Color4.Orange;
             });
         }
@@ -155,66 +136,47 @@ public void TestRightTextColour()
             });
         }
 
-        [Test]
-        public void TestRubyAlignment()
+        [TestCase(LyricTextAlignment.Auto, LyricTextAlignment.Auto)]
+        [TestCase(LyricTextAlignment.Auto, LyricTextAlignment.Center)]
+        [TestCase(LyricTextAlignment.Auto, LyricTextAlignment.EqualSpace)]
+        [TestCase(LyricTextAlignment.Center, LyricTextAlignment.Auto)]
+        [TestCase(LyricTextAlignment.Center, LyricTextAlignment.Center)]
+        [TestCase(LyricTextAlignment.Center, LyricTextAlignment.EqualSpace)]
+        [TestCase(LyricTextAlignment.EqualSpace, LyricTextAlignment.Auto)]
+        [TestCase(LyricTextAlignment.EqualSpace, LyricTextAlignment.Center)]
+        [TestCase(LyricTextAlignment.EqualSpace, LyricTextAlignment.EqualSpace)]
+        public void TestAlignment(LyricTextAlignment rubyAlignment, LyricTextAlignment romajiAlignment)
         {
-            AddStep("Test ruby alignment", () =>
+            AddStep("Change alignment", () =>
             {
-                karaokeSpriteText.RubyAlignment = LyricTextAlignment.EqualSpace;
+                karaokeSpriteText.RomajiAlignment = rubyAlignment;
+                karaokeSpriteText.RomajiAlignment = romajiAlignment;
             });
         }
 
-        [Test]
-        public void TestRomajiAlignment()
-        {
-            AddStep("Test romaji alignment", () =>
-            {
-                karaokeSpriteText.RomajiAlignment = LyricTextAlignment.EqualSpace;
-            });
-        }
-
-        [Test]
-        public void TestSpacing()
+        [TestCase(null, null, null)]
+        [TestCase("(10,0)", null, null)]
+        [TestCase(null, "(10,0)", null)]
+        [TestCase(null, null, "(10,0)")]
+        public void TestSpacing(string spacing, string rubySpacing, string romajiSpacing)
         {
             AddStep("Change spacing", () =>
             {
-                karaokeSpriteText.Spacing = new Vector2(10);
+                karaokeSpriteText.Spacing = TestCaseVectorHelper.ParseVector2(spacing);
+                karaokeSpriteText.RubySpacing = TestCaseVectorHelper.ParseVector2(rubySpacing);
+                karaokeSpriteText.RomajiSpacing = TestCaseVectorHelper.ParseVector2(romajiSpacing);
             });
         }
 
-        [Test]
-        public void TestRubySpacing()
-        {
-            AddStep("Change ruby spacing", () =>
-            {
-                karaokeSpriteText.RubySpacing = new Vector2(10);
-            });
-        }
-
-        [Test]
-        public void TestRomajiSpacing()
-        {
-            AddStep("Change romaji spacing", () =>
-            {
-                karaokeSpriteText.RomajiSpacing = new Vector2(10);
-            });
-        }
-
-        [Test]
-        public void TestRubyMargin()
-        {
-            AddStep("Change ruby margin", () =>
-            {
-                karaokeSpriteText.RubyMargin = 10;
-            });
-        }
-
-        [Test]
-        public void TestRomajiMargin()
+        [TestCase(0, 0)]
+        [TestCase(0, 20)]
+        [TestCase(20, 0)]
+        public void TestMarginPadding(int rubyMargin, int romajiMargin)
         {
-            AddStep("Change romaji margin", () =>
+            AddStep("Change margin", () =>
             {
-                karaokeSpriteText.RomajiMargin = 10;
+                karaokeSpriteText.RubyMargin = rubyMargin;
+                karaokeSpriteText.RomajiMargin = romajiMargin;
             });
         }
     }

From ac057811d3c1dcbe98d329d4060f94eca38e11c7 Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 22:03:02 +0800
Subject: [PATCH 6/7] Let it able to adjust time by slider.

---
 .../TestSceneKaraokeSpriteTextWithShader.cs   | 37 +++++++------------
 1 file changed, 14 insertions(+), 23 deletions(-)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteTextWithShader.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteTextWithShader.cs
index 34a8bbc..40da926 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteTextWithShader.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteTextWithShader.cs
@@ -1,14 +1,13 @@
 // Copyright (c) karaoke.dev <contact@karaoke.dev>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-using System;
-using System.Collections.Generic;
 using NUnit.Framework;
 using osu.Framework.Extensions;
 using osu.Framework.Font.Tests.Helper;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Shaders;
 using osu.Framework.Graphics.Sprites;
+using osu.Framework.Timing;
 using osuTK;
 using osuTK.Graphics;
 
@@ -16,21 +15,30 @@ namespace osu.Framework.Font.Tests.Visual.Sprites
 {
     public class TestSceneKaraokeSpriteTextWithShader : BackgroundGridTestScene
     {
-        private readonly KaraokeSpriteText karaokeSpriteText;
+        private readonly ManualClock manualClock = new();
+
+        private readonly TestKaraokeSpriteText karaokeSpriteText;
 
         public TestSceneKaraokeSpriteTextWithShader()
         {
-            Child = karaokeSpriteText = new KaraokeSpriteText
+            Child = karaokeSpriteText = new TestKaraokeSpriteText
             {
                 Anchor = Anchor.Centre,
                 Origin = Anchor.Centre,
                 Text = "カラオケ！",
                 Rubies = TestCaseTagHelper.ParseParsePositionTexts(new[] { "[0,1]:か", "[1,2]:ら", "[2,3]:お", "[3,4]:け" }),
                 Romajies = TestCaseTagHelper.ParseParsePositionTexts(new[] { "[0,1]:ka", "[1,2]:ra", "[2,3]:o", "[3,4]:ke" }),
+                TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { "[0,start]:500", "[1,start]:600", "[2,start]:1000", "[3,start]:1500", "[4,start]:2000" }),
                 Scale = new Vector2(2),
                 LeftTextColour = Color4.Green,
                 RightTextColour = Color4.Red,
+                Clock = new FramedClock(manualClock),
             };
+
+            AddSliderStep("Adjust clock time", 0, 3000, 1000, time =>
+            {
+                manualClock.CurrentTime = time;
+            });
         }
 
         [Test]
@@ -103,26 +111,9 @@ public void ApplyRightLyricTextShader()
             });
         }
 
-        protected new void AddStep(string description, Action action)
+        private class TestKaraokeSpriteText : KaraokeSpriteText
         {
-            base.AddStep(description, () =>
-            {
-                action?.Invoke();
-                resetTime();
-            });
-
-            void resetTime()
-            {
-                var startTime = Time.Current;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    { new TextIndex(0), startTime + 500 },
-                    { new TextIndex(1), startTime + 600 },
-                    { new TextIndex(2), startTime + 1000 },
-                    { new TextIndex(3), startTime + 1500 },
-                    { new TextIndex(4), startTime + 2000 },
-                };
-            }
+            public override bool RemoveCompletedTransforms => false;
         }
     }
 }

From 44a93452179acce3afc42abd66690f8b63154955 Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Wed, 27 Apr 2022 22:04:26 +0800
Subject: [PATCH 7/7] Remove manual clock test case because it can be tested in
 another test scene.

---
 .../Sprites/TestSceneKaraokeSpriteText.cs     | 34 -------------------
 1 file changed, 34 deletions(-)

diff --git a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
index 9dc3f4d..88f1766 100644
--- a/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
+++ b/osu.Framework.Font.Tests/Visual/Sprites/TestSceneKaraokeSpriteText.cs
@@ -1,20 +1,17 @@
 // Copyright (c) karaoke.dev <contact@karaoke.dev>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-using System.Collections.Generic;
 using System.Linq;
 using NUnit.Framework;
 using osu.Framework.Font.Tests.Helper;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Testing;
-using osu.Framework.Timing;
 using osuTK.Graphics;
 
 namespace osu.Framework.Font.Tests.Visual.Sprites
 {
     public class TestSceneKaraokeSpriteText : TestScene
     {
-        private readonly ManualClock manualClock = new();
         private readonly KaraokeSpriteText karaokeSpriteText;
 
         public TestSceneKaraokeSpriteText()
@@ -29,37 +26,6 @@ public TestSceneKaraokeSpriteText()
             };
         }
 
-        [TestCase(false)]
-        [TestCase(true)]
-        public void TestKaraokeSpriteTextClock(bool manualTime)
-        {
-            if (manualTime)
-            {
-                AddSliderStep("Here can adjust time", 0, 3000, 1000, time =>
-                {
-                    manualClock.CurrentTime = time;
-                });
-            }
-
-            AddStep("Apply time-tags", () =>
-            {
-                var startTime = getStartTime();
-
-                karaokeSpriteText.Clock = manualTime ? new FramedClock(manualClock) : Clock;
-                karaokeSpriteText.TimeTags = new Dictionary<TextIndex, double>
-                {
-                    { new TextIndex(0), startTime + 500 },
-                    { new TextIndex(1), startTime + 600 },
-                    { new TextIndex(2), startTime + 1000 },
-                    { new TextIndex(3), startTime + 1500 },
-                    { new TextIndex(4), startTime + 2000 },
-                };
-            });
-
-            double getStartTime()
-                => manualTime ? 0 : Clock.CurrentTime;
-        }
-
         [TestCase(new[] { "[0,start]:500", "[1,start]:600", "[2,start]:1000", "[3,start]:1500", "[4,start]:2000" }, true)] // Normal time-tag.
         [TestCase(new[] { "[0,start]:0", "[0,end]:100", "[1,start]:1000", "[1,end]:1100", "[2,start]:2000", "[2,end]:2100", "[3,start]:3000", "[3,end]:3100", "[4,start]:4000", "[4,end]:4100" }, true)]
         [TestCase(new[] { "[-1,start]:0", "[0,start]:500", "[1,end]:600", "[2,start]:1000", "[3,end]:1500", "[4,end]:2000", "[8,end]:2500" }, true)] // Out-of-range time-tag, but it's acceptable now.