From 22668016a977192cc42e0a9348c2df5941ea825d Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Fri, 21 Jul 2023 00:24:29 +0800
Subject: [PATCH 1/3] Re-write the helper for more flexibility.

---
 .../Helper/TestCaseTagHelper.cs               | 233 +++++++++++-------
 1 file changed, 140 insertions(+), 93 deletions(-)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs b/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs
index 5f67d8080..ec29dea40 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Helper/TestCaseTagHelper.cs
@@ -1,6 +1,7 @@
 // Copyright (c) andy840119 <andy840119@gmail.com>. Licensed under the GPL Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
@@ -18,157 +19,203 @@ namespace osu.Game.Rulesets.Karaoke.Tests.Helper;
 
 public static class TestCaseTagHelper
 {
+    private const string char_index_range_str = @"\[(?<start>[-0-9]+)(?:,(?<end>[-0-9]+))?\]";
+    private const string time_index_regex = @"\[(?<index>[-0-9]+),(?<state>start|end)]";
+    private const string time_range_str = @"\[(?<startTime>[-0-9]+)(?:,(?<endTime>[-0-9]+))?\]";
+    private const string id_str = "(?<id>[-0-9]+)]";
+
+    private static string getStringPropertyRegex(char prefix, string propertyName)
+        => @$"(?:{prefix}(?<{propertyName}>[^\s]+))?";
+
+    private static string getNumberPropertyRegex(char prefix, string propertyName)
+        => $"(?:{prefix}(?<{propertyName}>[-0-9]+|s*|))?";
+
+    private static string generateRegex(string regexPrefix, IEnumerable<string> regexProperties)
+        => regexPrefix + string.Join("", regexProperties);
+
+    private static TObject getMatchByStatement<TObject>(string? str, string regexStr, Func<Match?, TObject> returnValue)
+    {
+        if (string.IsNullOrEmpty(str))
+            return returnValue(null);
+
+        var regex = new Regex(regexStr);
+        var result = regex.Match(str);
+        if (!result.Success)
+            throw new RegexMatchTimeoutException(nameof(str));
+
+        return returnValue(result);
+    }
+
     /// <summary>
     /// Process test case ruby string format into <see cref="RubyTag"/>
     /// </summary>
     /// <example>
-    /// [0]:ruby
-    /// [0,3]:ruby
+    /// [0]:ruby        -> has range index with text. <br/>
+    /// [0,3]:ruby      -> has range index with text. <br/>
+    /// [0]:            -> has range index with empty text. <br/>
+    /// [0,3]:          -> has range index with empty text. <br/>
+    /// [0]             -> has range index with empty text. <br/>
+    /// [0,3]           -> has range index with empty text. <br/>
     /// </example>
     /// <param name="str">Ruby tag string format</param>
     /// <returns><see cref="RubyTag"/>Ruby tag object</returns>
     public static RubyTag ParseRubyTag(string? str)
     {
-        if (string.IsNullOrEmpty(str))
-            return new RubyTag();
-
-        var regex = new Regex("\\[(?<start>[-0-9]+)(?:,(?<end>[-0-9]+))?\\]:(?<ruby>.*$)");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        string regex = generateRegex(char_index_range_str, new[]
+        {
+            getStringPropertyRegex(':', "ruby"),
+        });
 
-        string startValue = result.Groups["start"].Value;
-        string endValue = result.Groups["end"].Value;
+        return getMatchByStatement<RubyTag>(str, regex, result =>
+        {
+            if (result == null)
+                return new RubyTag();
 
-        int startIndex = int.Parse(startValue);
-        int endIndex = int.Parse(string.IsNullOrEmpty(endValue) ? startValue : endValue);
-        string text = result.Groups["ruby"].Value;
+            int startIndex = result.GetGroupValue<int>("start");
+            int? endIndex = result.GetGroupValue<int?>("end");
+            string text = result.GetGroupValue<string>("ruby");
 
-        return new RubyTag
-        {
-            StartIndex = startIndex,
-            EndIndex = endIndex,
-            Text = text,
-        };
+            return new RubyTag
+            {
+                StartIndex = startIndex,
+                EndIndex = endIndex ?? startIndex,
+                Text = text,
+            };
+        });
     }
 
     /// <summary>
     /// Process test case romaji string format into <see cref="RomajiTag"/>
     /// </summary>
     /// <example>
-    /// [0]:romaji
-    /// [0,3]:romaji
+    /// [0]:romaji          -> has range index with text. <br/>
+    /// [0,3]:romaji        -> has range index with text. <br/>
+    /// [0]:                -> has range index with empty text. <br/>
+    /// [0,3]:              -> has range index with empty text. <br/>
+    /// [0]                 -> has range index with empty text. <br/>
+    /// [0,3]               -> has range index with empty text. <br/>
     /// </example>
     /// <param name="str">Romaji tag string format</param>
     /// <returns><see cref="RomajiTag"/>Romaji tag object</returns>
     public static RomajiTag ParseRomajiTag(string? str)
     {
-        if (string.IsNullOrEmpty(str))
-            return new RomajiTag();
-
-        var regex = new Regex("\\[(?<start>[-0-9]+)(?:,(?<end>[-0-9]+))?\\]:(?<romaji>.*$)");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        string regex = generateRegex(char_index_range_str, new[]
+        {
+            getStringPropertyRegex(':', "romaji"),
+        });
 
-        string startValue = result.Groups["start"].Value;
-        string endValue = result.Groups["end"].Value;
+        return getMatchByStatement<RomajiTag>(str, regex, result =>
+        {
+            if (result == null)
+                return new RomajiTag();
 
-        int startIndex = int.Parse(startValue);
-        int endIndex = int.Parse(string.IsNullOrEmpty(endValue) ? startValue : endValue);
-        string text = result.Groups["romaji"].Value;
+            int startIndex = result.GetGroupValue<int>("start");
+            int? endIndex = result.GetGroupValue<int?>("end");
+            string text = result.GetGroupValue<string>("romaji");
 
-        return new RomajiTag
-        {
-            StartIndex = startIndex,
-            EndIndex = endIndex,
-            Text = text,
-        };
+            return new RomajiTag
+            {
+                StartIndex = startIndex,
+                EndIndex = endIndex ?? startIndex,
+                Text = text,
+            };
+        });
     }
 
     /// <summary>
     /// Process test case time tag string format into <see cref="TimeTag"/>
     /// </summary>
     /// <example>
-    /// [0,start]:1000
+    /// [0,start]:1000              -> has time-tag index with time. <br/>
+    /// [0,start]                   -> has time-tag index with no time. <br/>
+    /// [0,start]:                  -> has time-tag index with no time. <br/>
     /// </example>
     /// <param name="str">Time tag string format</param>
     /// <returns><see cref="TimeTag"/>Time tag object</returns>
     public static TimeTag ParseTimeTag(string? str)
     {
-        if (string.IsNullOrEmpty(str))
-            return new TimeTag(new TextIndex());
+        string regex = generateRegex(time_index_regex, new[]
+        {
+            getNumberPropertyRegex(':', "time"),
+        });
 
-        var regex = new Regex("(?<index>[-0-9]+),(?<state>start|end)]:(?<time>[-0-9]+|s*|)");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        return getMatchByStatement<TimeTag>(str, regex, result =>
+        {
+            if (result == null)
+                return new TimeTag(new TextIndex());
 
-        int index = result.GetGroupValue<int>("index");
-        var state = result.GetGroupValue<string>("state") == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
-        int? time = result.GetGroupValue<int?>("time");
+            int index = result.GetGroupValue<int>("index");
+            var state = result.GetGroupValue<string>("state") == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
+            int? time = result.GetGroupValue<int?>("time");
 
-        return new TimeTag(new TextIndex(index, state), time);
+            return new TimeTag(new TextIndex(index, state), time);
+        });
     }
 
     /// <summary>
     /// Process test case text index string format into <see cref="TextIndex"/>
     /// </summary>
     /// <example>
-    /// [0,start]
+    /// [0,start]   -> has time-tag index with time. <br/>
+    /// [0,end]     -> has time-tag index with time. <br/>
     /// </example>
     /// <param name="str">Text tag string format</param>
     /// <returns><see cref="TimeTag"/>Text tag object</returns>
     public static TextIndex ParseTextIndex(string? str)
     {
-        if (string.IsNullOrEmpty(str))
-            return new TextIndex();
+        string regex = generateRegex(time_index_regex, Array.Empty<string>());
 
-        var regex = new Regex("(?<index>[-0-9]+),(?<state>start|end)]");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        return getMatchByStatement(str, regex, result =>
+        {
+            if (result == null)
+                return new TextIndex();
 
-        int index = result.GetGroupValue<int>("index");
-        var state = result.GetGroupValue<string>("state") == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
+            int index = result.GetGroupValue<int>("index");
+            var state = result.GetGroupValue<string>("state") == "start" ? TextIndex.IndexState.Start : TextIndex.IndexState.End;
 
-        return new TextIndex(index, state);
+            return new TextIndex(index, state);
+        });
     }
 
     /// <summary>
     /// Process test case lyric string format into <see cref="Lyric"/>
     /// </summary>
     /// <example>
-    /// [1000,3000]:karaoke
+    /// [1000,3000]:karaoke     -> has time-range and lyric. <br/>
+    /// [1000,3000]:            -> has time-range. <br/>
+    /// [1000,3000]             -> has time-range. <br/>
     /// </example>
     /// <param name="str">Lyric string format</param>
     /// <param name="id">Id if needed</param>
     /// <returns><see cref="Lyric"/>Lyric object</returns>
     public static Lyric ParseLyric(string str, int? id = null)
     {
-        if (string.IsNullOrEmpty(str))
-            return new Lyric();
+        string regex = generateRegex(time_range_str, new[]
+        {
+            getStringPropertyRegex(':', "lyric"),
+        });
 
-        var regex = new Regex("(?<startTime>[-0-9]+),(?<endTime>[-0-9]+)]:(?<lyric>.*$)");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        return getMatchByStatement<Lyric>(str, regex, result =>
+        {
+            if (result == null)
+                return new Lyric();
 
-        double startTime = result.GetGroupValue<double>("startTime");
-        double endTime = result.GetGroupValue<double>("endTime");
-        string text = result.GetGroupValue<string>("lyric");
+            double startTime = result.GetGroupValue<double>("startTime");
+            double endTime = result.GetGroupValue<double>("endTime");
+            string text = result.GetGroupValue<string>("lyric");
 
-        return new Lyric
-        {
-            StartTime = startTime,
-            Duration = endTime - startTime,
-            Text = text,
-            TimeTags = new[]
+            return new Lyric
             {
-                new TimeTag(new TextIndex(0), startTime),
-                new TimeTag(new TextIndex(text.Length - 1, TextIndex.IndexState.End), endTime),
-            },
-        }.ChangeId(id != null ? TestCaseElementIdHelper.CreateElementIdByNumber(id.Value) : ElementId.Empty);
+                StartTime = startTime,
+                Duration = endTime - startTime,
+                Text = text,
+                TimeTags = new[]
+                {
+                    new TimeTag(new TextIndex(0), startTime),
+                    new TimeTag(new TextIndex(text.Length - 1, TextIndex.IndexState.End), endTime),
+                },
+            }.ChangeId(id != null ? TestCaseElementIdHelper.CreateElementIdByNumber(id.Value) : ElementId.Empty);
+        });
     }
 
     /// <summary>
@@ -202,26 +249,26 @@ public static Lyric ParseLyricWithTimeTag(string? str)
     /// Process test case singer string format into <see cref="Singer"/>
     /// </summary>
     /// <example>
-    /// [0]name:singer001
-    /// [0]romaji:singer001
-    /// [0]eg:singer001
+    /// [0]name:singer001       -> singer with id and name. <br/>
+    /// [0]romaji:singer001     -> singer with id and romaji. <br/>
+    /// [0]eg:singer001         -> singer with id and english name. <br/>
     /// </example>
     /// <param name="str">Singer string format</param>
     /// <returns><see cref="Singer"/>sSinger object</returns>
     public static Singer ParseSinger(string? str)
     {
-        if (string.IsNullOrEmpty(str))
-            return new Singer().ChangeId(ElementId.Empty);
+        string regex = generateRegex(id_str, Array.Empty<string>());
 
-        var regex = new Regex("(?<id>[-0-9]+)]");
-        var result = regex.Match(str);
-        if (!result.Success)
-            throw new RegexMatchTimeoutException(nameof(str));
+        return getMatchByStatement<Singer>(str, regex, result =>
+        {
+            if (result == null)
+                return new Singer().ChangeId(ElementId.Empty);
 
-        // todo : implementation
-        int id = result.GetGroupValue<int>("id");
+            // todo : implementation
+            int id = result.GetGroupValue<int>("id");
 
-        return new Singer().ChangeId(id);
+            return new Singer().ChangeId(id);
+        });
     }
 
     public static RubyTag[] ParseRubyTags(IEnumerable<string?> strings)

From 487ad92d0f60ee1bc1a7741c05cce3229591a62b Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Fri, 21 Jul 2023 22:22:37 +0800
Subject: [PATCH 2/3] remove un-need ":" before the time-tag index because
 default value of the empty time is 0.

---
 .../Beatmaps/Formats/LrcEncoderTest.cs        |  4 +-
 .../Editor/Checks/CheckLyricTimeTagTest.cs    |  6 +-
 .../Checks/CheckNoteReferenceLyricTest.cs     | 12 +--
 .../Editor/Checks/CheckNoteTimeTest.cs        | 24 +++---
 .../Lyrics/Notes/NoteGeneratorTest.cs         |  6 +-
 .../TimeTags/Ja/JaTimeTagGeneratorTest.cs     | 78 +++++++++----------
 .../TimeTags/TimeTagGeneratorSelectorTest.cs  |  6 +-
 .../TimeTags/Zh/ZhTimeTagGeneratorTest.cs     |  6 +-
 .../Objects/Utils/LyricUtilsTest.cs           | 16 ++--
 .../Objects/Utils/LyricsUtilsTest.cs          |  6 +-
 .../Objects/Utils/TimeTagUtilsTest.cs         |  6 +-
 .../Objects/Utils/TimeTagsUtilsTest.cs        | 32 ++++----
 12 files changed, 101 insertions(+), 101 deletions(-)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/Formats/LrcEncoderTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/Formats/LrcEncoderTest.cs
index 4e545724a..779bc1792 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/Formats/LrcEncoderTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/Formats/LrcEncoderTest.cs
@@ -56,9 +56,9 @@ private static Beatmap decode(string filename, out Beatmap encoded)
 
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" }, new double[] { 1100, 2000, 2100, 3000 })]
     [TestCase(new[] { "[1,end]:3000", "[1,start]:2100", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1100, 2000, 2100, 3000 })]
-    [TestCase(new[] { "[0,start]:", "[0,start]:", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1100, 2000 })]
+    [TestCase(new[] { "[0,start]", "[0,start]", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1100, 2000 })]
     [TestCase(new[] { "[0,start]:1000", "[0,start]:1100", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1000, 2000 })]
-    [TestCase(new[] { "[0,start]:", "[0,end]:", "[0,start]:", "[1,start]:", "[1,end]:" }, new double[] { })]
+    [TestCase(new[] { "[0,start]", "[0,end]", "[0,start]", "[1,start]", "[1,end]" }, new double[] { })]
     [TestCase(new[] { "[0,start]:2000", "[0,end]:1000" }, new double[] { 2000, 2000 })]
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2100", "[1,start]:2000", "[1,end]:3000" }, new double[] { 1100, 2100, 2100, 3000 })]
     [TestCase(new[] { "[0,start]:1000", "[0,end]:5000", "[1,start]:2000", "[1,end]:3000" }, new double[] { 1000, 5000, 5000, 5000 })]
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckLyricTimeTagTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckLyricTimeTagTest.cs
index af8298bf3..040a4b1a0 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckLyricTimeTagTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckLyricTimeTagTest.cs
@@ -87,9 +87,9 @@ public void TestCheckOverlapping(string text, string[] timeTags)
         AssertNotOk<LyricTimeTagIssue, IssueTemplateLyricTimeTagOverlapping>(lyric);
     }
 
-    [TestCase("カラオケ", new[] { "[0,start]:", "[3,end]:1000" })] // empty start time-tag time.
-    [TestCase("カラオケ", new[] { "[0,start]:1000", "[3,end]:" })] // empty end time-tag time.
-    [TestCase("カラオケ", new[] { "[0,start]:1000", "[1,start]:", "[3,end]:2000" })] // empty center time-tag time.
+    [TestCase("カラオケ", new[] { "[0,start]", "[3,end]:1000" })] // empty start time-tag time.
+    [TestCase("カラオケ", new[] { "[0,start]:1000", "[3,end]" })] // empty end time-tag time.
+    [TestCase("カラオケ", new[] { "[0,start]:1000", "[1,start]", "[3,end]:2000" })] // empty center time-tag time.
     public void TestCheckEmptyTime(string text, string[] timeTags)
     {
         var lyric = new Lyric
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteReferenceLyricTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteReferenceLyricTest.cs
index 4621bdede..de9714a59 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteReferenceLyricTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteReferenceLyricTest.cs
@@ -107,9 +107,9 @@ public void TestCheckMissingStartReferenceTimeTag(int referenceTimeTagIndex, str
         AssertNotOk<NoteIssue, IssueTemplateNoteMissingStartReferenceTimeTag>(new HitObject[] { referencedLyric, note });
     }
 
-    [TestCase(0, new[] { "[0,start]:", "[3,end]:5000" })]
-    [TestCase(0, new[] { "[0,start]:", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]:5000" })]
-    [TestCase(1, new[] { "[0,start]:1000", "[1,start]:", "[2,start]:3000", "[3,start]:4000", "[3,end]:5000" })]
+    [TestCase(0, new[] { "[0,start]", "[3,end]:5000" })]
+    [TestCase(0, new[] { "[0,start]", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]:5000" })]
+    [TestCase(1, new[] { "[0,start]:1000", "[1,start]", "[2,start]:3000", "[3,start]:4000", "[3,end]:5000" })]
     public void TestCheckStartReferenceTimeTagMissingTime(int referenceTimeTagIndex, string[] timeTags)
     {
         var referencedLyric = new Lyric
@@ -146,9 +146,9 @@ public void TestCheckMissingEndReferenceTimeTag(int referenceTimeTagIndex, strin
         AssertNotOk<NoteIssue, IssueTemplateNoteMissingEndReferenceTimeTag>(new HitObject[] { referencedLyric, note });
     }
 
-    [TestCase(0, new[] { "[0,start]:1000", "[3,end]:" })]
-    [TestCase(3, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]:" })]
-    [TestCase(2, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:", "[3,end]:5000" })]
+    [TestCase(0, new[] { "[0,start]:1000", "[3,end]" })]
+    [TestCase(3, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]" })]
+    [TestCase(2, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]", "[3,end]:5000" })]
     public void TestCheckEndReferenceTimeTagMissingTime(int referenceTimeTagIndex, string[] timeTags)
     {
         var referencedLyric = new Lyric
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
index 9e90824b9..188ab74d7 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
@@ -46,8 +46,8 @@ public void TestCheckWithNoReferenceLyric()
         AssertOk(new HitObject[] { note });
     }
 
-    [TestCase(3, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]:" })] // will missing start time-tag.
-    [TestCase(2, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:", "[3,end]:5000" })] // will missing end time-tag.
+    [TestCase(3, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]" })] // will missing start time-tag.
+    [TestCase(2, new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]", "[3,end]:5000" })] // will missing end time-tag.
     public void TestCheckMissingStartOrEndTimeTag(int referenceTimeTagIndex, string[] timeTags)
     {
         var referencedLyric = new Lyric
@@ -88,11 +88,11 @@ public void TestCheckInvalidReferenceTimeTagTime(string startTimeTag, string end
         AssertNotOk<NoteIssue, IssueTemplateNoteInvalidReferenceTimeTagTime>(new HitObject[] { referencedLyric, note });
     }
 
-    [TestCase("[0,start]:", "[1,start]:")]
-    [TestCase("[0,end]:", "[1,end]:")]
-    [TestCase("[0,start]:", "[1,end]:")]
-    [TestCase("[0,end]:", "[1,start]:")]
-    [TestCase("[1,start]:", "[0,start]:")] // should have error even if time-tag index is not sorted. we did not care about the time-tag index in here.
+    [TestCase("[0,start]", "[1,start]")]
+    [TestCase("[0,end]", "[1,end]")]
+    [TestCase("[0,start]", "[1,end]")]
+    [TestCase("[0,end]", "[1,start]")]
+    [TestCase("[1,start]", "[0,start]")] // should have error even if time-tag index is not sorted. we did not care about the time-tag index in here.
     public void TestCheckDurationTooShort(string startTimeTag, string endTimeTag)
     {
         var referencedLyric = new Lyric
@@ -110,11 +110,11 @@ public void TestCheckDurationTooShort(string startTimeTag, string endTimeTag)
         AssertNotOk<NoteIssue, IssueTemplateNoteDurationTooShort>(new HitObject[] { referencedLyric, note });
     }
 
-    [TestCase("[0,start]:", "[1,start]:")]
-    [TestCase("[0,end]:", "[1,end]:")]
-    [TestCase("[0,start]:", "[1,end]:")]
-    [TestCase("[0,end]:", "[1,start]:")]
-    [TestCase("[1,start]:", "[0,start]:")] // should have error even if time-tag index is not sorted. we did not care about the time-tag index in here.
+    [TestCase("[0,start]", "[1,start]")]
+    [TestCase("[0,end]", "[1,end]")]
+    [TestCase("[0,start]", "[1,end]")]
+    [TestCase("[0,end]", "[1,start]")]
+    [TestCase("[1,start]", "[0,start]")] // should have error even if time-tag index is not sorted. we did not care about the time-tag index in here.
     public void TestCheckDurationTooLong(string startTimeTag, string endTimeTag)
     {
         var referencedLyric = new Lyric
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/Notes/NoteGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/Notes/NoteGeneratorTest.cs
index da5fddaf4..49772018c 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/Notes/NoteGeneratorTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/Notes/NoteGeneratorTest.cs
@@ -14,10 +14,10 @@ public class NoteGeneratorTest : BaseLyricGeneratorTest<NoteGenerator, Note[], N
 {
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000", "[3,end]:5000" }, true)]
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000" }, true)]
-    [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:" }, false)] // all time-tag should with time.
-    [TestCase(new[] { "[0,start]:1000", "[1,start]:" }, false)] // should have at least two time-tags with time.
+    [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]" }, false)] // all time-tag should with time.
+    [TestCase(new[] { "[0,start]:1000", "[1,start]" }, false)] // should have at least two time-tags with time.
     [TestCase(new[] { "[0,start]:1000" }, false)] // should have at least two time-tags.
-    [TestCase(new[] { "[0,start]:" }, false)] // no-time.
+    [TestCase(new[] { "[0,start]" }, false)] // no-time.
     [TestCase(new string[] { }, false)]
     public void TestCanGenerate(string[] timeTags, bool canGenerate)
     {
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs
index 454d5d85f..77c1eb698 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Ja/JaTimeTagGeneratorTest.cs
@@ -21,16 +21,16 @@ public void TestCanGenerate(string text, bool canGenerate)
         CheckCanGenerate(text, canGenerate, config);
     }
 
-    [TestCase("がんばって", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false)]
-    [TestCase("がんばって", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[4,start]:" }, true)]
+    [TestCase("がんばって", new[] { "[0,start]", "[2,start]", "[4,start]" }, false)]
+    [TestCase("がんばって", new[] { "[0,start]", "[1,start]", "[2,start]", "[4,start]" }, true)]
     public void TestGenerateWithCheckWhiteCheckん(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x => x.Checkん.Value = applyConfig);
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("買って", new[] { "[0,start]:", "[2,start]:" }, false)]
-    [TestCase("買って", new[] { "[0,start]:", "[1,start]:", "[2,start]:" }, true)]
+    [TestCase("買って", new[] { "[0,start]", "[2,start]" }, false)]
+    [TestCase("買って", new[] { "[0,start]", "[1,start]", "[2,start]" }, true)]
     public void TestGenerateWithCheckっ(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x => x.Checkっ.Value = applyConfig);
@@ -38,31 +38,31 @@ public void TestGenerateWithCheckっ(string lyric, string[] expectedTimeTags, bo
     }
 
     [TestCase(" ", new string[] { }, false)]
-    [TestCase(" ", new[] { "[0,start]:" }, true)]
+    [TestCase(" ", new[] { "[0,start]" }, true)]
     public void TestGenerateWithCheckBlankLine(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x => x.CheckBlankLine.Value = applyConfig);
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("か", new[] { "[0,start]:" }, false)]
-    [TestCase("か", new[] { "[0,start]:", "[0,end]:" }, true)]
+    [TestCase("か", new[] { "[0,start]" }, false)]
+    [TestCase("か", new[] { "[0,start]", "[0,end]" }, true)]
     public void TestGenerateWithCheckLineEndKeyUp(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x => x.CheckLineEndKeyUp.Value = applyConfig);
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("か     ", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:", "[5,start]:" }, false)]
-    [TestCase("か     ", new[] { "[0,start]:", "[1,start]:" }, true)]
+    [TestCase("か     ", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]", "[5,start]" }, false)]
+    [TestCase("か     ", new[] { "[0,start]", "[1,start]" }, true)]
     public void TestGenerateWithCheckWhiteSpace(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x => x.CheckWhiteSpace.Value = applyConfig);
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("か ", new[] { "[0,start]:", "[1,start]:" }, false)]
-    [TestCase("か ", new[] { "[0,start]:", "[0,end]:" }, true)]
+    [TestCase("か ", new[] { "[0,start]", "[1,start]" }, false)]
+    [TestCase("か ", new[] { "[0,start]", "[0,end]" }, true)]
     public void TestGenerateWithCheckWhiteSpaceKeyUp(string lyric, string[] expectedTimeTags, bool applyConfig)
     {
         var config = GeneratorEmptyConfig(x =>
@@ -73,12 +73,12 @@ public void TestGenerateWithCheckWhiteSpaceKeyUp(string lyric, string[] expected
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("a　b　c", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false, false)]
-    [TestCase("a　b　c", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:" }, true, false)]
-    [TestCase("a　b　c", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
-    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false, false)]
-    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:" }, true, false)]
-    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
+    [TestCase("a　b　c", new[] { "[0,start]", "[2,start]", "[4,start]" }, false, false)]
+    [TestCase("a　b　c", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]" }, true, false)]
+    [TestCase("a　b　c", new[] { "[0,start]", "[0,end]", "[2,start]", "[2,end]", "[4,start]" }, true, true)]
+    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]", "[2,start]", "[4,start]" }, false, false)]
+    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]" }, true, false)]
+    [TestCase("Ａ　Ｂ　Ｃ", new[] { "[0,start]", "[0,end]", "[2,start]", "[2,end]", "[4,start]" }, true, true)]
     public void TestGenerateWithCheckWhiteSpaceAlphabet(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
     {
         var config = GeneratorEmptyConfig(x =>
@@ -90,12 +90,12 @@ public void TestGenerateWithCheckWhiteSpaceAlphabet(string lyric, string[] expec
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("0　1　2", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false, false)]
-    [TestCase("0　1　2", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:" }, true, false)]
-    [TestCase("0　1　2", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
-    [TestCase("０　１　２", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false, false)]
-    [TestCase("０　１　２", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:" }, true, false)]
-    [TestCase("０　１　２", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
+    [TestCase("0　1　2", new[] { "[0,start]", "[2,start]", "[4,start]" }, false, false)]
+    [TestCase("0　1　2", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]" }, true, false)]
+    [TestCase("0　1　2", new[] { "[0,start]", "[0,end]", "[2,start]", "[2,end]", "[4,start]" }, true, true)]
+    [TestCase("０　１　２", new[] { "[0,start]", "[2,start]", "[4,start]" }, false, false)]
+    [TestCase("０　１　２", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]" }, true, false)]
+    [TestCase("０　１　２", new[] { "[0,start]", "[0,end]", "[2,start]", "[2,end]", "[4,start]" }, true, true)]
     public void TestGenerateWithCheckWhiteSpaceDigit(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
     {
         var config = GeneratorEmptyConfig(x =>
@@ -107,9 +107,9 @@ public void TestGenerateWithCheckWhiteSpaceDigit(string lyric, string[] expected
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
 
-    [TestCase("!　!　!", new[] { "[0,start]:", "[2,start]:", "[4,start]:" }, false, false)]
-    [TestCase("!　!　!", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:" }, true, false)]
-    [TestCase("!　!　!", new[] { "[0,start]:", "[0,end]:", "[2,start]:", "[2,end]:", "[4,start]:" }, true, true)]
+    [TestCase("!　!　!", new[] { "[0,start]", "[2,start]", "[4,start]" }, false, false)]
+    [TestCase("!　!　!", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]" }, true, false)]
+    [TestCase("!　!　!", new[] { "[0,start]", "[0,end]", "[2,start]", "[2,end]", "[4,start]" }, true, true)]
     public void TestGenerateWitCheckWhiteSpaceAsciiSymbol(string lyric, string[] expectedTimeTags, bool applyConfig, bool keyUp)
     {
         var config = GeneratorEmptyConfig(x =>
@@ -147,19 +147,19 @@ public void TestGenerateWithRubyLyric()
 
         string[] expectedTimeTags =
         {
-            "[0,start]:",
-            "[0,start]:",
-            "[0,start]:",
-            "[2,start]:",
-            "[4,start]:",
-            "[6,start]:",
-            "[7,start]:",
-            "[7,start]:",
-            "[8,start]:",
-            "[9,start]:",
-            "[10,start]:",
-            "[12,start]:",
-            "[13,start]:",
+            "[0,start]",
+            "[0,start]",
+            "[0,start]",
+            "[2,start]",
+            "[4,start]",
+            "[6,start]",
+            "[7,start]",
+            "[7,start]",
+            "[8,start]",
+            "[9,start]",
+            "[10,start]",
+            "[12,start]",
+            "[13,start]",
         };
         CheckGenerateResult(lyric, expectedTimeTags, config);
     }
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/TimeTagGeneratorSelectorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/TimeTagGeneratorSelectorTest.cs
index 21be31de5..4976d77c5 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/TimeTagGeneratorSelectorTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/TimeTagGeneratorSelectorTest.cs
@@ -30,9 +30,9 @@ public void TestCanGenerate(int lcid, string text, bool canGenerate)
         CheckCanGenerate(lyric, canGenerate, selector);
     }
 
-    [TestCase(17, "か", new[] { "[0,start]:", "[0,end]:" })] // Japanese
-    [TestCase(1041, "か", new[] { "[0,start]:", "[0,end]:" })] // Japanese
-    [TestCase(1028, "喵", new[] { "[0,start]:" })] // Chinese
+    [TestCase(17, "か", new[] { "[0,start]", "[0,end]" })] // Japanese
+    [TestCase(1041, "か", new[] { "[0,start]", "[0,end]" })] // Japanese
+    [TestCase(1028, "喵", new[] { "[0,start]" })] // Chinese
     public void TestGenerate(int lcid, string text, string[] expectedTimeTags)
     {
         var selector = CreateSelector();
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs
index 3d2356610..2fd9ce870 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Generator/Lyrics/TimeTags/Zh/ZhTimeTagGeneratorTest.cs
@@ -20,9 +20,9 @@ public void TestCanGenerate(string text, bool canGenerate)
         CheckCanGenerate(text, canGenerate, config);
     }
 
-    [TestCase("測試一些歌詞", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:", "[4,start]:", "[5,start]:", "[5,end]:" })]
-    [TestCase("拉拉拉~~~", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[5,end]:" })]
-    [TestCase("拉~拉~拉~", new[] { "[0,start]:", "[2,start]:", "[4,start]:", "[5,end]:" })]
+    [TestCase("測試一些歌詞", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]", "[4,start]", "[5,start]", "[5,end]" })]
+    [TestCase("拉拉拉~~~", new[] { "[0,start]", "[1,start]", "[2,start]", "[5,end]" })]
+    [TestCase("拉~拉~拉~", new[] { "[0,start]", "[2,start]", "[4,start]", "[5,end]" })]
     public void TestGenerateWithCheckLineEndKeyUp(string lyric, string[] expectedTimeTags)
     {
         var config = GeneratorEmptyConfig(x => x.CheckLineEndKeyUp.Value = true);
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricUtilsTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricUtilsTest.cs
index afde6bffa..2644c5301 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricUtilsTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricUtilsTest.cs
@@ -72,7 +72,7 @@ public void TestRemoveTextRomaji(string[] romajies, int charGap, int count, stri
     }
 
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" }, 0, 2, new[] { "[0,start]:3000", "[1,start]:4000" })]
-    [TestCase(new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:" }, 0, 2, new[] { "[0,start]:", "[1,start]:" })]
+    [TestCase(new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]" }, 0, 2, new[] { "[0,start]", "[1,start]" })]
     [TestCase(new[] { "[0,start]:1000", "[2,start]:3000" }, 1, 2, new[] { "[0,start]:1000" })]
     public void TestRemoveTextTimeTag(string[] timeTags, int charGap, int count, string[] actualTimeTags)
     {
@@ -140,9 +140,9 @@ public void TextAddTextRomaji(string[] romajies, int charGap, string addedText,
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" }, 0, "karaoke", new[] { "[7,start]:1000", "[8,start]:2000", "[9,start]:3000", "[10,start]:4000" })]
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" }, 2, "karaoke", new[] { "[0,start]:1000", "[1,start]:2000", "[9,start]:3000", "[10,start]:4000" })]
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" }, 4, "karaoke", new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" })]
-    [TestCase(new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:" }, 0, "karaoke", new[] { "[7,start]:", "[8,start]:", "[9,start]:", "[10,start]:" })]
-    [TestCase(new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:" }, 2, "karaoke", new[] { "[0,start]:", "[1,start]:", "[9,start]:", "[10,start]:" })]
-    [TestCase(new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:" }, 4, "karaoke", new[] { "[0,start]:", "[1,start]:", "[2,start]:", "[3,start]:" })]
+    [TestCase(new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]" }, 0, "karaoke", new[] { "[7,start]", "[8,start]", "[9,start]", "[10,start]" })]
+    [TestCase(new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]" }, 2, "karaoke", new[] { "[0,start]", "[1,start]", "[9,start]", "[10,start]" })]
+    [TestCase(new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]" }, 4, "karaoke", new[] { "[0,start]", "[1,start]", "[2,start]", "[3,start]" })]
     public void TestAddTextTimeTag(string[] timeTags, int charGap, string addedText, string[] actualTimeTags)
     {
         var lyric = new Lyric
@@ -296,11 +296,11 @@ public void TestLyricTimeFormattedString(double startTime, double endTime, strin
     [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[2,start]:3000", "[3,start]:4000" }, "00:01:000 - 00:04:000")]
     [TestCase(new[] { "[0,start]:4000", "[1,start]:3000", "[2,start]:2000", "[3,start]:1000" }, "00:01:000 - 00:04:000")] // should display right-time even it's not being ordered.
     [TestCase(new[] { "[3,start]:4000", "[2,start]:3000", "[1,start]:2000", "[0,start]:1000" }, "00:01:000 - 00:04:000")] // should display right-time even it's not being ordered.
-    [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[1,start]:" }, "00:01:000 - 00:02:000")] // with null case.
-    [TestCase(new[] { "[1,start]:", "[0,start]:1000", "[1,start]:2000" }, "00:01:000 - 00:02:000")] // with null case.
-    [TestCase(new[] { "[0,start]:1000", "[1,start]:" }, "00:01:000 - 00:01:000")] // with null case.
+    [TestCase(new[] { "[0,start]:1000", "[1,start]:2000", "[1,start]" }, "00:01:000 - 00:02:000")] // with null case.
+    [TestCase(new[] { "[1,start]", "[0,start]:1000", "[1,start]:2000" }, "00:01:000 - 00:02:000")] // with null case.
+    [TestCase(new[] { "[0,start]:1000", "[1,start]" }, "00:01:000 - 00:01:000")] // with null case.
     [TestCase(new[] { "[0,start]:1000" }, "00:01:000 - 00:01:000")]
-    [TestCase(new[] { "[0,start]:" }, "--:--:--- - --:--:---")] // with null case.
+    [TestCase(new[] { "[0,start]" }, "--:--:--- - --:--:---")] // with null case.
     [TestCase(new string[] { }, "--:--:--- - --:--:---")]
     public void TestTimeTagTimeFormattedString(string[] timeTags, string expected)
     {
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricsUtilsTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricsUtilsTest.cs
index 5767f29f2..a0bc6e2bf 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricsUtilsTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/LyricsUtilsTest.cs
@@ -170,11 +170,11 @@ public void TestCombineLyricText(string firstText, string secondText, string exp
         Assert.AreEqual(expected, combineLyric.Text);
     }
 
-    [TestCase(new[] { "[0,start]:" }, new[] { "[0,start]:" }, new[] { "[0,start]:", "[7,start]:" })]
-    [TestCase(new[] { "[0,end]:" }, new[] { "[0,end]:" }, new[] { "[0,end]:", "[7,end]:" })]
+    [TestCase(new[] { "[0,start]" }, new[] { "[0,start]" }, new[] { "[0,start]", "[7,start]" })]
+    [TestCase(new[] { "[0,end]" }, new[] { "[0,end]" }, new[] { "[0,end]", "[7,end]" })]
     [TestCase(new[] { "[0,start]:1000" }, new[] { "[0,start]:1000" }, new[] { "[0,start]:1000", "[7,start]:1000" })] // deal with the case with time.
     [TestCase(new[] { "[0,start]:1000" }, new[] { "[0,start]:-1000" }, new[] { "[0,start]:1000", "[7,start]:-1000" })] // deal with the case with not invalid time tag time.
-    [TestCase(new[] { "[-1,start]:" }, new[] { "[-1,start]:" }, new[] { "[-1,start]:", "[6,start]:" })] // deal with the case with not invalid time tag position.
+    [TestCase(new[] { "[-1,start]" }, new[] { "[-1,start]" }, new[] { "[-1,start]", "[6,start]" })] // deal with the case with not invalid time tag position.
     public void TestCombineLyricTimeTag(string[] firstTimeTags, string[] secondTimeTags, string[] expectTimeTags)
     {
         var lyric1 = new Lyric
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagUtilsTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagUtilsTest.cs
index 4c1f370e0..2b0f45c16 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagUtilsTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagUtilsTest.cs
@@ -11,8 +11,8 @@ public class TimeTagUtilsTest
 {
     [TestCase("[1,start]:1000", 2, "[3,start]:1000")]
     [TestCase("[1,end]:1000", 2, "[3,end]:1000")]
-    [TestCase("[1,start]:", 2, "[3,start]:")]
-    [TestCase("[1,end]:", 2, "[3,end]:")]
+    [TestCase("[1,start]", 2, "[3,start]")]
+    [TestCase("[1,end]", 2, "[3,end]")]
     [TestCase("[1,start]:1000", -2, "[-1,start]:1000")]
     [TestCase("[1,end]:1000", -2, "[-1,end]:1000")]
     public void TestShiftingTimeTag(string shiftingTag, int offset, string expectedTimeTag)
@@ -29,7 +29,7 @@ public void TestShiftingTimeTag(string shiftingTag, int offset, string expectedT
     [TestCase("[1,end]:1000", "00:01:000")]
     [TestCase("[-1,start]:1000", "00:01:000")]
     [TestCase("[-1,start]:-1000", "-00:01:000")]
-    [TestCase("[-1,start]:", "--:--:---")]
+    [TestCase("[-1,start]", "--:--:---")]
     public void TestFormattedString(string tag, string expected)
     {
         var timeTag = TestCaseTagHelper.ParseTimeTag(tag);
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagsUtilsTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagsUtilsTest.cs
index bffd865c4..93b16239d 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagsUtilsTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Objects/Utils/TimeTagsUtilsTest.cs
@@ -16,13 +16,13 @@ public class TimeTagsUtilsTest
     [TestCase("[1,start]:1000", "[3,start]:3000", 2, "[2,start]:2000")]
     [TestCase("[1,start]:1000", "[3,end]:4000", 2, "[2,start]:2000")]
     [TestCase("[1,end]:2000", "[3,start]:3000", 2, "[2,start]:2000")]
-    [TestCase("[1,start]:", "[3,start]:3000", 2, "[2,start]:")]
-    [TestCase("[1,start]:1000", "[3,start]:", 2, "[2,start]:")]
-    [TestCase("[1,start]:", "[3,start]:", 2, "[2,start]:")]
-    [TestCase("[0,start]:", "[0,start]:", 0, "[0,start]:")] // edge case, but it's valid.
-    [TestCase("[1,start]:", "[3,start]:", 10, null)] // new index should be in the range.
-    [TestCase("[10,start]:", "[3,start]:", 10, null)] // start index should be smaller then end index.
-    [TestCase("[1,start]:", null, 2, null)] // should not be null.
+    [TestCase("[1,start]", "[3,start]:3000", 2, "[2,start]")]
+    [TestCase("[1,start]:1000", "[3,start]", 2, "[2,start]")]
+    [TestCase("[1,start]", "[3,start]", 2, "[2,start]")]
+    [TestCase("[0,start]", "[0,start]", 0, "[0,start]")] // edge case, but it's valid.
+    [TestCase("[1,start]", "[3,start]", 10, null)] // new index should be in the range.
+    [TestCase("[10,start]", "[3,start]", 10, null)] // start index should be smaller then end index.
+    [TestCase("[1,start]", null, 2, null)] // should not be null.
     public void GenerateTimeTag(string startTag, string? endTag, int index, string? result)
     {
         var startTimeTag = TestCaseTagHelper.ParseTimeTag(startTag);
@@ -44,9 +44,9 @@ public void GenerateTimeTag(string startTag, string? endTag, int index, string?
 
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" }, new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" })]
     [TestCase(new[] { "[1,end]:3000", "[1,start]:2100", "[0,end]:2000", "[0,start]:1100" }, new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" })]
-    [TestCase(new[] { "[0,start]:", "[0,start]:", "[0,end]:2000", "[0,start]:1100" }, new[] { "[0,start]:", "[0,start]:", "[0,start]:1100", "[0,end]:2000" })]
+    [TestCase(new[] { "[0,start]", "[0,start]", "[0,end]:2000", "[0,start]:1100" }, new[] { "[0,start]", "[0,start]", "[0,start]:1100", "[0,end]:2000" })]
     [TestCase(new[] { "[0,start]:1000", "[0,start]:1100", "[0,end]:2000", "[0,start]:1100" }, new[] { "[0,start]:1000", "[0,start]:1100", "[0,start]:1100", "[0,end]:2000" })]
-    [TestCase(new[] { "[0,start]:", "[0,end]:", "[0,start]:", "[1,start]:", "[1,end]:" }, new[] { "[0,start]:", "[0,start]:", "[0,end]:", "[1,start]:", "[1,end]:" })]
+    [TestCase(new[] { "[0,start]", "[0,end]", "[0,start]", "[1,start]", "[1,end]" }, new[] { "[0,start]", "[0,start]", "[0,end]", "[1,start]", "[1,end]" })]
     public void TestSort(string[] timeTagTexts, string[] expectedTimeTags)
     {
         var timeTags = TestCaseTagHelper.ParseTimeTags(timeTagTexts);
@@ -69,8 +69,8 @@ public void TestFindOutOfRange(string text, string[] timeTagTexts, string[] inva
         TimeTagAssert.ArePropertyEqual(expected, actual);
     }
 
-    [TestCase(new[] { "[0,start]:1000", "[1,start]:", "[2,start]:3000", "[3,start]:", "[3,end]:5000" }, new[] { "[1,start]:", "[3,start]:" })]
-    [TestCase(new[] { "[0,start]:", "[3,end]:" }, new[] { "[0,start]:", "[3,end]:" })]
+    [TestCase(new[] { "[0,start]:1000", "[1,start]", "[2,start]:3000", "[3,start]", "[3,end]:5000" }, new[] { "[1,start]", "[3,start]" })]
+    [TestCase(new[] { "[0,start]", "[3,end]" }, new[] { "[0,start]", "[3,end]" })]
     public void TestFindNoneTime(string[] timeTagTexts, string[] invalidTimeTags)
     {
         var timeTags = TestCaseTagHelper.ParseTimeTags(timeTagTexts);
@@ -161,7 +161,7 @@ public void TestFixOverlapping(string[] timeTagTexts, GroupCheck other, SelfChec
 
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" }, new double[] { 1100, 2000, 2100, 3000 })]
     [TestCase(new[] { "[0,start]:3000", "[0,end]:2100", "[1,start]:2000", "[1,end]:1100" }, new double[] { 1100, 2000, 2100, 3000 })] // will sort by time.
-    [TestCase(new[] { "[0,start]:", "[0,start]:", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1100, 2000 })] // will remove the time-tag with no time.
+    [TestCase(new[] { "[0,start]", "[0,start]", "[0,end]:2000", "[0,start]:1100" }, new double[] { 1100, 2000 })] // will remove the time-tag with no time.
     [TestCase(new[] { "[0,start]:1000", "[0,start]:1100" }, new double[] { 1000, 1100 })] // will remain the duplicated time-tag index.
     [TestCase(new[] { "[0,start]:1000", "[1,start]:1000" }, new double[] { 1000 })] // Should not add duplicated time.
     public void TestToTimeBasedDictionary(string[] timeTagTexts, double[] expected)
@@ -174,8 +174,8 @@ public void TestToTimeBasedDictionary(string[] timeTagTexts, double[] expected)
 
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" }, 1100)]
     [TestCase(new[] { "[1,end]:3000", "[1,start]:2100", "[0,end]:2000", "[0,start]:1100" }, 1100)]
-    [TestCase(new[] { "[0,start]:", "[0,start]:", "[0,end]:2000", "[0,start]:1100" }, 1100)]
-    [TestCase(new[] { "[0,start]:" }, null)]
+    [TestCase(new[] { "[0,start]", "[0,start]", "[0,end]:2000", "[0,start]:1100" }, 1100)]
+    [TestCase(new[] { "[0,start]" }, null)]
     [TestCase(new string[] { }, null)]
     public void TestGetStartTime(string[] timeTagTexts, double? expected)
     {
@@ -187,8 +187,8 @@ public void TestGetStartTime(string[] timeTagTexts, double? expected)
 
     [TestCase(new[] { "[0,start]:1100", "[0,end]:2000", "[1,start]:2100", "[1,end]:3000" }, 3000)]
     [TestCase(new[] { "[1,end]:3000", "[1,start]:2100", "[0,end]:2000", "[0,start]:1100" }, 3000)]
-    [TestCase(new[] { "[0,start]:", "[0,start]:", "[0,end]:2000", "[0,start]:1100" }, 2000)]
-    [TestCase(new[] { "[0,start]:" }, null)]
+    [TestCase(new[] { "[0,start]", "[0,start]", "[0,end]:2000", "[0,start]:1100" }, 2000)]
+    [TestCase(new[] { "[0,start]" }, null)]
     [TestCase(new string[] { }, null)]
     public void TestGetEndTime(string[] timeTagTexts, double? expected)
     {

From 4017eb7aff50cba5365690fe1ee0797c3c983a16 Mon Sep 17 00:00:00 2001
From: andy840119 <andy840119@gmail.com>
Date: Fri, 21 Jul 2023 22:40:49 +0800
Subject: [PATCH 3/3] Add missing ":"

---
 .../Editor/Checks/CheckNoteTimeTest.cs                        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
index 188ab74d7..194019855 100644
--- a/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
+++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/Checks/CheckNoteTimeTest.cs
@@ -98,7 +98,7 @@ public void TestCheckDurationTooShort(string startTimeTag, string endTimeTag)
         var referencedLyric = new Lyric
         {
             Text = "カラオケ",
-            TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { $"{startTimeTag}0", $"{endTimeTag}{MIN_DURATION - 1}" }),
+            TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { $"{startTimeTag}:0", $"{endTimeTag}:{MIN_DURATION - 1}" }),
         };
         var note = new Note
         {
@@ -120,7 +120,7 @@ public void TestCheckDurationTooLong(string startTimeTag, string endTimeTag)
         var referencedLyric = new Lyric
         {
             Text = "カラオケ",
-            TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { $"{startTimeTag}0", $"{endTimeTag}{MAX_DURATION + 1}" }),
+            TimeTags = TestCaseTagHelper.ParseTimeTags(new[] { $"{startTimeTag}:0", $"{endTimeTag}:{MAX_DURATION + 1}" }),
         };
         var note = new Note
         {