Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all the .lrc file support to .kar #2231

Closed
andy840119 opened this issue May 12, 2024 · 1 comment
Closed

Replace all the .lrc file support to .kar #2231

andy840119 opened this issue May 12, 2024 · 1 comment
Labels
encoder/decoder About beatmap format decode/encoder Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.
Milestone
2024.0831

Comments

@andy840119
Copy link
Member

andy840119 commented May 12, 2024 •
edited
Loading

As discussion in the karaoke-dev/LrcParser#40
the .lrc file we are currently using might be the .kar file format.
Should:

  1. replace all the wording likelrc to the kar
  2. using the KarParser in the LrcParser package instead.
  3. add the description about kar file format, might be related to the txt2ass
  4. ass the kar or karParser into the typo white list.
@andy840119 andy840119 added encoder/decoder About beatmap format decode/encoder Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. labels May 12, 2024
@andy840119 andy840119 mentioned this issue Aug 10, 2024
Merged
@andy840119 andy840119 added this to the 2024.0831 milestone Aug 10, 2024
@andy840119
Copy link
Member Author

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoder/decoder About beatmap format decode/encoder Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion.
Projects
None yet
Milestone
2024.0831
Development

No branches or pull requests
1 participant
@andy840119