diff --git a/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/TestKaraokeBeatmap.cs b/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/TestKaraokeBeatmap.cs index bdd8791af..5d19521eb 100644 --- a/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/TestKaraokeBeatmap.cs +++ b/osu.Game.Rulesets.Karaoke.Tests/Beatmaps/TestKaraokeBeatmap.cs @@ -13,10 +13,6 @@ public class TestKaraokeBeatmap : Beatmap { public TestKaraokeBeatmap(RulesetInfo ruleset) { - // It's a tricky way not to trigger change handler throw exception. - // not a good solution, but seems ok because there's no other ruleset in the test case. - ruleset.OnlineID = 1; - var baseBeatmap = createTestBeatmap(); BeatmapInfo = baseBeatmap.BeatmapInfo; diff --git a/osu.Game.Rulesets.Karaoke.Tests/Editor/TestSceneKaraokeEditor.cs b/osu.Game.Rulesets.Karaoke.Tests/Editor/TestSceneKaraokeEditor.cs index 90b560f93..466425aa1 100644 --- a/osu.Game.Rulesets.Karaoke.Tests/Editor/TestSceneKaraokeEditor.cs +++ b/osu.Game.Rulesets.Karaoke.Tests/Editor/TestSceneKaraokeEditor.cs @@ -56,7 +56,6 @@ private void load() Dependencies.Cache(lyricCheckerManager); Dependencies.Cache(new EditorClock()); - Dependencies.CacheAs(new EditorChangeHandler(editorBeatmap)); } } } diff --git a/osu.Game.Rulesets.Karaoke/Edit/ImportLyric/LyricImporter.cs b/osu.Game.Rulesets.Karaoke/Edit/ImportLyric/LyricImporter.cs index ec99adcd2..7da929b11 100644 --- a/osu.Game.Rulesets.Karaoke/Edit/ImportLyric/LyricImporter.cs +++ b/osu.Game.Rulesets.Karaoke/Edit/ImportLyric/LyricImporter.cs @@ -29,7 +29,6 @@ public class LyricImporter : ScreenWithBeatmapBackground, IImportStateResolver private readonly BindableBeatDivisor beatDivisor = new(); private EditorBeatmap editorBeatmap; - private ImportLyricEditorChangeHandler changeHandler; private ImportLyricManager importManager; @@ -96,8 +95,6 @@ private void load() }; AddInternal(editorBeatmap = new EditorBeatmap(playableBeatmap)); dependencies.CacheAs(editorBeatmap); - changeHandler = new ImportLyricEditorChangeHandler(editorBeatmap); - dependencies.CacheAs(changeHandler); AddInternal(importManager = new ImportLyricManager()); dependencies.Cache(importManager); @@ -131,23 +128,5 @@ public LyricImporterWaveContainer() FourthWaveColour = Color4Extensions.FromHex(@"392850"); } } - - /// - /// Use this class as temp class until support customized beatmap. - /// - private class ImportLyricEditorChangeHandler : TransactionalCommitComponent, IEditorChangeHandler - { - public event Action OnStateChange; - - public ImportLyricEditorChangeHandler(EditorBeatmap editorBeatmap) - { - } - - protected override void UpdateState() - { - // do nothing. - OnStateChange?.Invoke(); - } - } } }