From 78282f9cb5fa3a160eb04f53a9b249e2d623b46e Mon Sep 17 00:00:00 2001 From: andy840119 Date: Sun, 18 Aug 2024 22:07:32 +0800 Subject: [PATCH] Change size button should inherit the ToolbarEditActionButton. --- .../Toolbar/View/AdjustFontSizeButton.cs | 82 +++++++++++++------ 1 file changed, 56 insertions(+), 26 deletions(-) diff --git a/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Content/Compose/Toolbar/View/AdjustFontSizeButton.cs b/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Content/Compose/Toolbar/View/AdjustFontSizeButton.cs index 126d2a08d..f702e4d98 100644 --- a/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Content/Compose/Toolbar/View/AdjustFontSizeButton.cs +++ b/osu.Game.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Content/Compose/Toolbar/View/AdjustFontSizeButton.cs @@ -8,7 +8,6 @@ using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Sprites; using osu.Game.Graphics.Sprites; -using osu.Game.Graphics.UserInterface; using osu.Game.Rulesets.Karaoke.Configuration; using osu.Game.Rulesets.Karaoke.Utils; using osuTK; @@ -21,10 +20,7 @@ public partial class AdjustFontSizeButton : CompositeDrawable public AdjustFontSizeButton() { - IconButton previousSizeButton; OsuSpriteText fontSizeSpriteText; - IconButton nextSizeButton; - float[] sizes = FontUtils.ComposerFontSize(); Height = SpecialActionToolbar.HEIGHT; AutoSizeAxes = Axes.X; @@ -36,18 +32,9 @@ public AdjustFontSizeButton() Direction = FillDirection.Horizontal, Children = new Drawable[] { - previousSizeButton = new IconButton + new DecreasePreviewFontSizeActionButton { Size = new Vector2(SpecialActionToolbar.ICON_SIZE), - Icon = FontAwesome.Solid.Minus, - Action = () => - { - float previousSize = sizes.GetPrevious(bindableFontSize.Value); - if (previousSize == default) - return; - - bindableFontSize.Value = previousSize; - }, }, new Container { @@ -59,18 +46,9 @@ public AdjustFontSizeButton() Origin = Anchor.Centre, }, }, - nextSizeButton = new IconButton + new IncreasePreviewFontSizeActionButton { Size = new Vector2(SpecialActionToolbar.ICON_SIZE), - Icon = FontAwesome.Solid.Plus, - Action = () => - { - float nextSize = sizes.GetNext(bindableFontSize.Value); - if (nextSize == default) - return; - - bindableFontSize.Value = nextSize; - }, }, }, }; @@ -78,8 +56,6 @@ public AdjustFontSizeButton() bindableFontSize.BindValueChanged(e => { fontSizeSpriteText.Text = FontUtils.GetText(e.NewValue); - previousSizeButton.Enabled.Value = sizes.GetPrevious(e.NewValue) != default; - nextSizeButton.Enabled.Value = sizes.GetNext(e.NewValue) != default; }); } @@ -88,4 +64,58 @@ private void load(KaraokeRulesetLyricEditorConfigManager lyricEditorConfigManage { lyricEditorConfigManager.BindWith(KaraokeRulesetLyricEditorSetting.FontSizeInComposer, bindableFontSize); } + + private partial class DecreasePreviewFontSizeActionButton : PreviewFontSizeActionButton + { + protected override KaraokeEditAction EditAction => KaraokeEditAction.DecreasePreviewFontSize; + + protected override float GetTriggeredFontSize(float[] sizes, float currentFontSize) => sizes.GetPrevious(currentFontSize); + + public DecreasePreviewFontSizeActionButton() + { + SetIcon(FontAwesome.Solid.Minus); + } + } + + private partial class IncreasePreviewFontSizeActionButton : PreviewFontSizeActionButton + { + protected override KaraokeEditAction EditAction => KaraokeEditAction.IncreasePreviewFontSize; + + protected override float GetTriggeredFontSize(float[] sizes, float currentFontSize) => sizes.GetNext(currentFontSize); + + public IncreasePreviewFontSizeActionButton() + { + SetIcon(FontAwesome.Solid.Plus); + } + } + + private abstract partial class PreviewFontSizeActionButton : ToolbarEditActionButton + { + private static readonly float[] sizes = FontUtils.ComposerFontSize(); + + private readonly Bindable bindableFontSize = new(); + + protected PreviewFontSizeActionButton() + { + Action = () => + { + float triggeredFontSize = GetTriggeredFontSize(sizes, bindableFontSize.Value); + bindableFontSize.Value = triggeredFontSize != default ? triggeredFontSize : bindableFontSize.Value; + }; + + bindableFontSize.BindValueChanged(e => + { + float triggeredFontSize = GetTriggeredFontSize(sizes, e.NewValue); + SetState(triggeredFontSize != default); + }); + } + + protected abstract float GetTriggeredFontSize(float[] sizes, float currentFontSize); + + [BackgroundDependencyLoader] + private void load(KaraokeRulesetLyricEditorConfigManager lyricEditorConfigManager) + { + lyricEditorConfigManager.BindWith(KaraokeRulesetLyricEditorSetting.FontSizeInComposer, bindableFontSize); + } + } }