From 68b448f6da62fc02202e18035d455196d8dfd14f Mon Sep 17 00:00:00 2001 From: andy840119 Date: Sat, 30 Jul 2022 18:24:30 +0800 Subject: [PATCH 1/2] Update the package to the latest. --- osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj index e6c8d67fa..0a3f12443 100644 --- a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj +++ b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj @@ -18,7 +18,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + From e56a4d7508f4acad5552dc861a75d6280fe6c0a6 Mon Sep 17 00:00:00 2001 From: andy840119 Date: Sat, 30 Jul 2022 18:24:48 +0800 Subject: [PATCH 2/2] Change the api broken. See https://github.com/ppy/osu/pull/19377 --- .../Edit/Components/Containers/EditorScrollContainer.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/osu.Game.Rulesets.Karaoke/Edit/Components/Containers/EditorScrollContainer.cs b/osu.Game.Rulesets.Karaoke/Edit/Components/Containers/EditorScrollContainer.cs index 5f954eceb..1aef044ae 100644 --- a/osu.Game.Rulesets.Karaoke/Edit/Components/Containers/EditorScrollContainer.cs +++ b/osu.Game.Rulesets.Karaoke/Edit/Components/Containers/EditorScrollContainer.cs @@ -28,8 +28,7 @@ protected EditorScrollContainer() void assignZoomRange(float _) { // we should make sure that will not cause error while assigning the size. - MaxZoom = Math.Max(BindableZoom.MaxValue, MinZoom); - MinZoom = Math.Min(BindableZoom.MinValue, MaxZoom); + SetupZoom(BindableZoom.Value, BindableZoom.MinValue, BindableZoom.MaxValue); } BindableZoom.BindValueChanged(e =>