From e72c1e5e12fe1625b5f856f891f4ad72572c47e6 Mon Sep 17 00:00:00 2001 From: andy840119 Date: Tue, 30 Jan 2024 21:57:08 +0800 Subject: [PATCH 1/4] Upgrade the pacakge to the latest. --- osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj index abf02c83e..f8c98a18c 100644 --- a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj +++ b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj @@ -18,7 +18,7 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - + From bb93dd372421266e0425bc8a95ad930f5591fd94 Mon Sep 17 00:00:00 2001 From: andy840119 Date: Tue, 30 Jan 2024 21:58:27 +0800 Subject: [PATCH 2/4] Fix the api broken. See: https://github.com/ppy/osu/pull/26617/files --- osu.Game.Rulesets.Karaoke.Tests/VisualTestRunner.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Karaoke.Tests/VisualTestRunner.cs b/osu.Game.Rulesets.Karaoke.Tests/VisualTestRunner.cs index 776396747..9dae0c8cc 100644 --- a/osu.Game.Rulesets.Karaoke.Tests/VisualTestRunner.cs +++ b/osu.Game.Rulesets.Karaoke.Tests/VisualTestRunner.cs @@ -11,7 +11,7 @@ public static class VisualTestRunner [STAThread] public static int Main(string[] args) { - using var host = Host.GetSuitableDesktopHost("karaoke-visual-test-runner", new HostOptions { BindIPC = true }); + using var host = Host.GetSuitableDesktopHost("karaoke-visual-test-runner"); host.Run(new KaraokeTestBrowser()); return 0; From 928eabba082511694d87030b45c62367633de8b8 Mon Sep 17 00:00:00 2001 From: andy840119 Date: Tue, 30 Jan 2024 21:59:01 +0800 Subject: [PATCH 3/4] this property being propetected. Also, lazer remove this effect. --- .../UI/TestSceneRulesetIcon.cs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/osu.Game.Rulesets.Karaoke.Tests/UI/TestSceneRulesetIcon.cs b/osu.Game.Rulesets.Karaoke.Tests/UI/TestSceneRulesetIcon.cs index f0b6349bf..7bb971887 100644 --- a/osu.Game.Rulesets.Karaoke.Tests/UI/TestSceneRulesetIcon.cs +++ b/osu.Game.Rulesets.Karaoke.Tests/UI/TestSceneRulesetIcon.cs @@ -3,11 +3,9 @@ using NUnit.Framework; using osu.Framework.Graphics; -using osu.Framework.Graphics.Effects; using osu.Game.Graphics.Containers; using osu.Game.Tests.Visual; using osuTK; -using osuTK.Graphics; namespace osu.Game.Rulesets.Karaoke.Tests.UI; @@ -21,13 +19,6 @@ public TestSceneRulesetIcon() Anchor = Anchor.Centre, Origin = Anchor.Centre, Icon = new KaraokeRuleset().CreateIcon(), - EdgeEffect = new EdgeEffectParameters - { - Type = EdgeEffectType.Glow, - Colour = new Color4(255, 194, 224, 100), - Radius = 15, - Roundness = 15, - }, Size = new Vector2(40), }; } From f7942556d960822b3a99ac70889a4be471d0f2fb Mon Sep 17 00:00:00 2001 From: andy840119 Date: Tue, 30 Jan 2024 22:00:07 +0800 Subject: [PATCH 4/4] Upgrade the test project. --- .../osu.Game.Rulesets.Karaoke.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj b/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj index 3d3161ee3..11222a504 100644 --- a/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj +++ b/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj @@ -14,7 +14,7 @@ - +