diff --git a/osu.Game.Rulesets.Karaoke/KaraokeRuleset.cs b/osu.Game.Rulesets.Karaoke/KaraokeRuleset.cs index a6a1bd3a2..bf386ccc7 100644 --- a/osu.Game.Rulesets.Karaoke/KaraokeRuleset.cs +++ b/osu.Game.Rulesets.Karaoke/KaraokeRuleset.cs @@ -239,17 +239,17 @@ public override StatisticRow[] CreateStatisticsForScore(ScoreInfo score, IBeatma { Columns = new[] { - new StatisticItem("Info", new BeatmapInfoGraph(playableBeatmap) + new StatisticItem("Info", () => new BeatmapInfoGraph(playableBeatmap) { RelativeSizeAxes = Axes.X, Height = info_height - }, new Dimension(GridSizeMode.Relative, 0.6f)), - new StatisticItem("", new Container(), new Dimension(GridSizeMode.Absolute, 10)), - new StatisticItem("Metadata", new BeatmapMetadataGraph(playableBeatmap) + }, dimension: new Dimension(GridSizeMode.Relative, 0.6f)), + new StatisticItem("", () => new Container(), dimension: new Dimension(GridSizeMode.Absolute, 10)), + new StatisticItem("Metadata", () => new BeatmapMetadataGraph(playableBeatmap) { RelativeSizeAxes = Axes.X, Height = info_height - }, new Dimension()) + }, dimension: new Dimension()) } }, }; @@ -263,7 +263,7 @@ public override StatisticRow[] CreateStatisticsForScore(ScoreInfo score, IBeatma { Columns = new[] { - new StatisticItem("Saiten Result", new SaitenResultGraph(score, playableBeatmap) + new StatisticItem("Saiten Result", () => new SaitenResultGraph(score, playableBeatmap) { RelativeSizeAxes = Axes.X, Height = remain_height - text_size - spacing @@ -277,7 +277,7 @@ public override StatisticRow[] CreateStatisticsForScore(ScoreInfo score, IBeatma { Columns = new[] { - new StatisticItem("Result", new NotScorableGraph + new StatisticItem("Result", () => new NotScorableGraph { RelativeSizeAxes = Axes.X, Height = remain_height - text_size - spacing diff --git a/osu.Game.Rulesets.Karaoke/Mods/KaraokeModFlashlight.cs b/osu.Game.Rulesets.Karaoke/Mods/KaraokeModFlashlight.cs index c0042b832..e2e680a66 100644 --- a/osu.Game.Rulesets.Karaoke/Mods/KaraokeModFlashlight.cs +++ b/osu.Game.Rulesets.Karaoke/Mods/KaraokeModFlashlight.cs @@ -24,7 +24,7 @@ public class KaraokeModFlashlight : ModFlashlight public override Type[] IncompatibleMods => new[] { typeof(ModHidden) }; [SettingSource("Flashlight size", "Multiplier applied to the default flashlight size.")] - public override BindableNumber SizeMultiplier { get; } = new() + public override BindableFloat SizeMultiplier { get; } = new() { MinValue = 0.5f, MaxValue = 3f, diff --git a/osu.Game.Rulesets.Karaoke/Replays/KaraokeFramedReplayInputHandler.cs b/osu.Game.Rulesets.Karaoke/Replays/KaraokeFramedReplayInputHandler.cs index 03353258b..a04182f8e 100644 --- a/osu.Game.Rulesets.Karaoke/Replays/KaraokeFramedReplayInputHandler.cs +++ b/osu.Game.Rulesets.Karaoke/Replays/KaraokeFramedReplayInputHandler.cs @@ -17,7 +17,7 @@ public KaraokeFramedReplayInputHandler(Replay replay) protected override bool IsImportant(KaraokeReplayFrame frame) => frame.Sound; - public override void CollectPendingInputs(List inputs) + protected override void CollectReplayInputs(List inputs) { inputs.Add(new ReplayState { diff --git a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj index b0da27cd4..2b3d63192 100644 --- a/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj +++ b/osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj @@ -12,7 +12,7 @@ - +