Achievement
- Get a new PR from the new contributor.
- Add the
contributor guideline
andlable
to let new contributor able to know which issue is friendly to resolve. - Adjust the caret state interface for let it able to support select range of the index.
Code quality
- Regular clean up code. karaoke
Editor
- Should be able to compare the caret position. karaoke
Need to know that which of the caret position(
click-down
caret position ordrag
caret position) is in the left or right side. - Rename property in caret state. karaoke
Rename from
release caret position
intodragging caret position
. - Implement the drag range caret position interface. karaoke
This interface is focus on provide the
click-down
anddrag
caret position. - Handle the case if user use
kayboard
to adjust the caret position after select range of the index. karaokeTrying to follow the same behavior like how normal text editor did.
- Make typing caret draggable. karaoke
- Rename edit mode enum. karaoke
Edit mode
is too general, renamed it intoedit step
. - Fix singer page cannot open in the production environment. karaoke
- Move
switch create time tag caret mode
out of lyric editor config. karaokeThis “edit state” does not need to save as user preference.
- Implement the
sub-section
for able to switch the edit mode in the lyric editor. karaokeThis sub-section able to show the switch state button with description.
- Should be able to drag the main lyric text to generate the ruby text. karaoke
- Moving index caret position should be only in the editable lyric. karaoke
Should not change the caret index in here.
- [Close duplicated] Should be able drag to select the lyric text in the typing. karaoke
Fix
- [Close duplicated] Refactor the issue tooltip.
- Fix drag in range of text in the lyric editor might have performance issue. karaoke
Tooling
- Add contribution guideline. karaoke
- Add CLA agreement to the new contributor. karaoke
Need to make sure that all source code from the contributor does not have legal issue to affect the current user.
- Add contribution guideline to let new contributor able to know what they can do to let their code more easier to be merged. karaoke