[Epic] k3s_server and k3s_agent tasks are not idempotent

[jon-stumpf]

The below tasks are repeated even when they are not needed. Fixes are forthcoming.

k3s_server

• Download K3s binary,

  k3s-ansible/roles/k3s_server/tasks/main.yml

  Line 13 in 19c206d

  - name: Download K3s binary

• Copy K3s service file [Single],

  k3s-ansible/roles/k3s_server/tasks/main.yml

  Line 26 in 19c206d

  - name: Copy K3s service file [Single]

• Copy config file to user home directory,

  k3s-ansible/roles/k3s_server/tasks/main.yml

  Line 70 in 19c206d

  - name: Copy config file to user home directory

• Add K3s autocomplete to user bashrc (Fixed #260: k3s autocompletion is added to .bashrc only when necessary; #262),

  k3s-ansible/roles/k3s_server/tasks/main.yml

  Line 78 in 19c206d

  - name: Add K3s autocomplete to user bashrc

• Change server to API endpoint instead of localhost,

  k3s-ansible/roles/k3s_server/tasks/main.yml

  Line 86 in 19c206d

  - name: Change server to API endpoint instead of localhost

k3s_agent

• Download K3s binary,

  k3s-ansible/roles/k3s_agent/tasks/main.yml

  Line 13 in 19c206d

  - name: Download K3s binary

• Copy K3s service file (Role tweaks #268),

  k3s-ansible/roles/k3s_agent/tasks/main.yml

  Line 23 in 19c206d

  - name: Copy K3s service file

[dereknola]

I assume most of this was me blindly putting in changed_when: true for these tasks 😳

[dereknola]

GH being dumb and autoclosing this issue.

[jon-stumpf]

FYI. I have been busy on other things and will be getting back to this after Christmas.

[alvsanand]

In step "Change server to API endpoint instead of localhost", kubeconfig must be set to "/etc/rancher/k3s/k3s.yaml". "~{{ ansible_user }}/.kube/config" is not used in the servers.

[dereknola]

Several more were addressed in #288

[peterklijn]

@dereknola now that #347 is merged, I believe all tasks are idempotent.
At least, in the setup I have running, a second run does not report any changes.

I think this issue can be closed.