Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_values seems to be not working correctly #6

Open
vinayrnagar opened this issue Jun 13, 2016 · 1 comment
Open

collect_values seems to be not working correctly #6

vinayrnagar opened this issue Jun 13, 2016 · 1 comment
Assignees

Comments

@vinayrnagar
Copy link

vinayrnagar commented Jun 13, 2016

collect_values does not seem to be working correctly. I am suspicious of these lines https://github.com/justiniso/polling/blob/master/polling.py#L112-L115 where the result that satisfies the check_success condition is not added to the queue but by definition of collect_values should have the

first value from the target function that meets the condions of the check_success
callback

Am I missing something here?

@justiniso justiniso self-assigned this Nov 24, 2016
@justiniso
Copy link
Owner

This is a valid error. Behavior and documentation are inconsistent.

@justiniso justiniso reopened this Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants