Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous behaviour when setting timeout to zero #25

Open
veliakiner opened this issue May 19, 2020 · 0 comments
Open

Ambiguous behaviour when setting timeout to zero #25

veliakiner opened this issue May 19, 2020 · 0 comments

Comments

@veliakiner
Copy link

When doing so, the behaviour can be one of two:

  1. Polls forever
  2. Polls for zero seconds (exits immediately)
    I believe it should be the latter, as the former case is designed to be explicitly set using the poll_forever parameter. However, instead it polls forever. This is because on polling.py::96 we check if timeout is truthy rather than not None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veliakiner