Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json and packagist.org #53

Open
gheydon opened this issue May 30, 2017 · 1 comment
Open

composer.json and packagist.org #53

gheydon opened this issue May 30, 2017 · 1 comment

Comments

@gheydon
Copy link

gheydon commented May 30, 2017

Can you include in the composer.json the type line

'type': 'drupal/module',

And also add this directly to packagist.org so that people who are deploying with composer can include this and automatically download all the dependencies your drupal installation.

I know you can do this with with the composer repositories on drupal.org, but it ignores the composer.json in your repository and doesn't include your dependencies you have listed.

Also a cool thing if you are using composer-patches you can just add the required patches to your root composer.json and it will apply them directly and stop when they do not apply. Keeping the patches fresh.

Thanks.
Gordon

@deviantintegral
Copy link
Collaborator

Adding the type makes sense.

I'm not 100% sure about the dependency thing. I've been only doing Drupal 8 work for the past two years or so, but packages.drupal.org reads dependencies that way. However, I have no idea how that works in Drupal 7 now.

And yes, composer-patches is great! I've found some bugs in bubbling up patches from dependencies, so we don't use it here, but for composer / D8 sites it's perfect. Note that it doesn't hard fail on conflicts by default, so watch out for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants