New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging and consing #3

Open

5 of 7 tasks

neongreen opened this issue Aug 4, 2020 · 0 comments

Assignees

Labels

Contributor

neongreen commented Aug 4, 2020 •

edited by srid

Loading

Vague inspiration: https://pursuit.purescript.org/packages/purescript-record/0.2.6/docs/Data.Record

Not sure about all of this, but:

union appends records and removes duplicates. Left-biased. Does not sort.
append appends records and does not remove duplicates.
insert adds a field to the beginning, but checks that the record does not contain that field already.
insertOrSet adds a field to the beginning, or replaces the existing field.

There have to be tests for all of these, including

should-not-typecheck tests for insert.

added by srid:

Fix a bug with append overwriting values (looks to affect Eq as well; ultimately because of RecTyIdxH)
Finish tests

The text was updated successfully, but these errors were encountered:

srid self-assigned this

srid added the enhancement label

neongreen mentioned this issue

[Question] Stance about key duplication #23

Open

kamoii mentioned this issue

Change append/combine implemantion to simply append records #24

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment